# iterative/dvc

dvc/dagascii.py

### Summary

B
4 hrs

#### Function `line` has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Confirmed

``````    def line(self, x0, y0, x1, y1, char):
"""Create a line on ASCII canvas.

Args:
x0 (int): x coordinate where the line should start.``````
Found in dvc/dagascii.py - About 3 hrs to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Function `draw` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open

``````def draw(vertexes, edges):
"""Build a DAG and draw it in ASCII.

Args:
vertexes (list): list of graph vertexes.``````
Found in dvc/dagascii.py - About 45 mins to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Function `line` has 5 arguments (exceeds 4 allowed). Consider refactoring. Open

``    def line(self, x0, y0, x1, y1, char):``
Found in dvc/dagascii.py - About 35 mins to fix

#### Similar blocks of code found in 3 locations. Consider refactoring. Wontfix

``````        elif y0 < y1:
for y in range(y0, y1 + 1):
if dy == 0:
x = x0
else:``````
Found in dvc/dagascii.py and 2 other locations - About 4 hrs to fix
dvc/dagascii.py on lines 144..150
dvc/dagascii.py on lines 151..164

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

## Refactorings

#### Similar blocks of code found in 3 locations. Consider refactoring. Wontfix

``````        elif abs(dx) >= abs(dy):
for x in range(x0, x1 + 1):
if dx == 0:
y = y0
else:``````
Found in dvc/dagascii.py and 2 other locations - About 4 hrs to fix
dvc/dagascii.py on lines 151..157
dvc/dagascii.py on lines 151..164

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.