iterative/dvc

View on GitHub
dvc/dagascii.py

Summary

Maintainability
C
1 day
Test Coverage

Function _do_draw has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    def _do_draw(self, screen):  # pragma: no cover
        # pylint: disable=too-many-locals
        # pylint: disable=too-many-branches, too-many-statements
        from dvc.system import System
        from asciimatics.event import KeyboardEvent
Severity: Minor
Found in dvc/dagascii.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function line has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    def line(self, x0, y0, x1, y1, char):
        """Create a line on ASCII canvas.

        Args:
            x0 (int): x coordinate where the line should start.
Severity: Minor
Found in dvc/dagascii.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File dagascii.py has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

"""Draws DAG in ASCII."""

from __future__ import unicode_literals
from __future__ import print_function

Severity: Minor
Found in dvc/dagascii.py - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Wontfix

                if k == screen.KEY_DOWN or k == ord("s"):
                    offset_y += 1
                elif k == screen.KEY_PAGE_DOWN or k == ord("S"):
                    offset_y += smaxrow
                elif k == screen.KEY_UP or k == ord("w"):
    Severity: Critical
    Found in dvc/dagascii.py - About 1 hr to fix

      Function draw has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def draw(vertexes, edges):
          """Build a DAG and draw it in ASCII.
      
          Args:
              vertexes (list): list of graph vertexes.
      Severity: Minor
      Found in dvc/dagascii.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function line has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def line(self, x0, y0, x1, y1, char):
      Severity: Minor
      Found in dvc/dagascii.py - About 35 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Wontfix

                elif abs(dx) >= abs(dy):
                    for x in range(x0, x1 + 1):
                        if dx == 0:
                            y = y0
                        else:
        Severity: Major
        Found in dvc/dagascii.py and 2 other locations - About 4 hrs to fix
        dvc/dagascii.py on lines 201..207
        dvc/dagascii.py on lines 201..214

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 85.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Wontfix

                elif y0 < y1:
                    for y in range(y0, y1 + 1):
                        if dy == 0:
                            x = x0
                        else:
        Severity: Major
        Found in dvc/dagascii.py and 2 other locations - About 4 hrs to fix
        dvc/dagascii.py on lines 194..200
        dvc/dagascii.py on lines 201..214

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 85.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Wontfix

                if self.cols + 1 > smaxcol:
                    max_x = self.cols + 1 - smaxcol
                else:
                    max_x = 0
        Severity: Major
        Found in dvc/dagascii.py and 1 other location - About 1 hr to fix
        dvc/dagascii.py on lines 83..86

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Wontfix

                if self.lines + 1 > smaxrow:
                    max_y = self.lines + 1 - smaxrow
                else:
                    max_y = 0
        Severity: Major
        Found in dvc/dagascii.py and 1 other location - About 1 hr to fix
        dvc/dagascii.py on lines 88..91

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status