iterative/dvc

View on GitHub
dvc/path_info.py

Summary

Maintainability
B
4 hrs
Test Coverage

URLInfo has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class URLInfo(object):
    DEFAULT_PORTS = {"http": 80, "https": 443, "ssh": 22, "hdfs": 0}

    def __init__(self, url):
        self.parsed = urlparse(url)
Severity: Minor
Found in dvc/path_info.py - About 2 hrs to fix

    Function from_parts has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def from_parts(
    Severity: Minor
    Found in dvc/path_info.py - About 45 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if isinstance(other, basestring):
                  other = self.__class__(other)
              elif self.__class__ != other.__class__:
                  return False
      Severity: Major
      Found in dvc/path_info.py and 1 other location - About 1 hr to fix
      dvc/path_info.py on lines 257..260

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if isinstance(other, basestring):
                  other = self.__class__(other)
              elif self.__class__ != other.__class__:
                  return False
      Severity: Major
      Found in dvc/path_info.py and 1 other location - About 1 hr to fix
      dvc/path_info.py on lines 61..64

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status