iterative/dvc

View on GitHub
dvc/remote/ssh/__init__.py

Summary

Maintainability
C
1 day
Test Coverage

RemoteSSH has 26 functions (exceeds 20 allowed). Consider refactoring.
Wontfix

class RemoteSSH(RemoteBASE):
    scheme = Schemes.SSH
    REQUIRES = {"paramiko": "paramiko"}

    JOBS = 4
Severity: Minor
Found in dvc/remote/ssh/__init__.py - About 3 hrs to fix

    File __init__.py has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    from __future__ import unicode_literals
    
    import errno
    import getpass
    import io
    Severity: Minor
    Found in dvc/remote/ssh/__init__.py - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

              if url:
                  parsed = urlparse(url)
                  user_ssh_config = self._load_user_ssh_config(parsed.hostname)
      
                  host = user_ssh_config.get("hostname", parsed.hostname)
      Severity: Major
      Found in dvc/remote/ssh/__init__.py - About 1 hr to fix

        Function batch_exists has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def batch_exists(self, path_infos, callback):
                def _exists(chunk_and_channel):
                    chunk, channel = chunk_and_channel
                    ret = []
                    for path in chunk:
        Severity: Minor
        Found in dvc/remote/ssh/__init__.py - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Invalid

            def move(self, from_info, to_info):
                if from_info.scheme != self.scheme or to_info.scheme != self.scheme:
                    raise NotImplementedError
        
                with self.ssh(from_info) as ssh:
        Severity: Major
        Found in dvc/remote/ssh/__init__.py and 1 other location - About 3 hrs to fix
        dvc/remote/ssh/__init__.py on lines 210..215

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Invalid

            def reflink(self, from_info, to_info):
                if from_info.scheme != self.scheme or to_info.scheme != self.scheme:
                    raise NotImplementedError
        
                with self.ssh(from_info) as ssh:
        Severity: Major
        Found in dvc/remote/ssh/__init__.py and 1 other location - About 3 hrs to fix
        dvc/remote/ssh/__init__.py on lines 224..229

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def copy(self, from_info, to_info):
                if not from_info.scheme == to_info.scheme == self.scheme:
                    raise NotImplementedError
        
                with self.ssh(from_info) as ssh:
        Severity: Major
        Found in dvc/remote/ssh/__init__.py and 1 other location - About 2 hrs to fix
        dvc/remote/ssh/__init__.py on lines 183..188

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def symlink(self, from_info, to_info):
                if not from_info.scheme == to_info.scheme == self.scheme:
                    raise NotImplementedError
        
                with self.ssh(from_info) as ssh:
        Severity: Major
        Found in dvc/remote/ssh/__init__.py and 1 other location - About 2 hrs to fix
        dvc/remote/ssh/__init__.py on lines 176..181

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if not self.no_traverse:
                    return list(set(checksums) & set(self.all()))
        Severity: Minor
        Found in dvc/remote/ssh/__init__.py and 1 other location - About 45 mins to fix
        dvc/remote/base.py on lines 746..747

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                with Tqdm(
                    desc="Querying "
                    + ("cache in " + name if name else "remote cache"),
                    total=len(checksums),
        Severity: Minor
        Found in dvc/remote/ssh/__init__.py and 1 other location - About 45 mins to fix
        dvc/remote/base.py on lines 749..752

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status