Sign upLogin

iterative/dvc

View on GitHub
Star
dvc/repo/metrics/show.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function show has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

def show(
Severity: Major
Found in dvc/repo/metrics/show.py - About 1 hr to fix

    Function show has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def show(
    repo,
    targets=None,
    all_branches=False,
    all_tags=False,
    Severity: Minor
    Found in dvc/repo/metrics/show.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _read_metrics has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def _read_metrics(repo, metrics, rev, onerror=None):
    fs = DVCFileSystem(repo=repo)

    relpath = ""
    if repo.root_dir != repo.fs.path.getcwd():
    Severity: Minor
    Found in dvc/repo/metrics/show.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _gather_metrics has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def _gather_metrics(repo, targets, rev, recursive, onerror=None):
    Severity: Minor
    Found in dvc/repo/metrics/show.py - About 35 mins to fix

      Function _extract_metrics has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Wontfix

      def _extract_metrics(metrics, path, rev):
    if isinstance(metrics, (int, float, str)):
        return metrics

    if not isinstance(metrics, dict):
      Severity: Minor
      Found in dvc/repo/metrics/show.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status