Sign upLogin

iterative/dvc

View on GitHub
Star
dvc/testing/fixtures.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function make_tmp_dir has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

def make_tmp_dir(tmp_path_factory, request, worker_id):
    def make(name, *, scm=False, dvc=False, subdir=False):
        from shutil import copytree, ignore_patterns

        from dvc.repo import Repo
Severity: Minor
Found in dvc/testing/fixtures.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function make has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def make(name, *, scm=False, dvc=False, subdir=False):
Severity: Minor
Found in dvc/testing/fixtures.py - About 35 mins to fix

    Function docker_services has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def docker_services(tmp_path_factory, request):
    from filelock import FileLock

    if os.environ.get("CI") and os.name == "nt":
        pytest.skip("disabled for Windows on CI")
    Severity: Minor
    Found in dvc/testing/fixtures.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status