Sign upLogin

iterative/dvc

View on GitHub
Star
dvc/testing/remote_tests.py

Summary

Maintainability
F
6 days
Test Coverage

File remote_tests.py has 323 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import os
import shutil

import pytest
Severity: Minor
Found in dvc/testing/remote_tests.py - About 3 hrs to fix

    Function test_dir has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def test_dir(self, tmp_dir, dvc, run_copy, remote_version_aware):  # noqa: PLR0915
        (stage,) = tmp_dir.dvc_gen(
            {
                "data_dir": {
                    "data_sub_dir": {"data_sub": "data_sub"},
    Severity: Major
    Found in dvc/testing/remote_tests.py - About 2 hrs to fix

      Function test has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def test(self, tmp_dir, dvc, remote):
        (stage,) = tmp_dir.dvc_gen("foo", "foo")
        out = stage.outs[0]
        cache = out.cache_path
        foo_hash = out.hash_info
      Severity: Minor
      Found in dvc/testing/remote_tests.py - About 1 hr to fix

        Function test_update has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def test_update(self, tmp_dir, dvc, remote_worktree):
        (foo_stage,) = tmp_dir.dvc_gen("foo", "foo")
        (data_dir_stage,) = tmp_dir.dvc_gen(
            {
                "data_dir": {
        Severity: Minor
        Found in dvc/testing/remote_tests.py - About 1 hr to fix

          Function test_file has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def test_file(self, tmp_dir, dvc, run_copy, remote_version_aware):
        (stage,) = tmp_dir.dvc_gen("foo", "foo")
        run_copy("foo", "foo_copy", name="copy")

        assert dvc.push()
          Severity: Minor
          Found in dvc/testing/remote_tests.py - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                @pytest.mark.xfail(raises=NotImplementedError, strict=False)
    def test_pull_no_00_prefix(self, tmp_dir, dvc, remote, monkeypatch):
        # Related: https://github.com/iterative/dvc/issues/6244

        fs_type = type(dvc.cloud.get_remote_odb("upstream").fs)
            Severity: Major
            Found in dvc/testing/remote_tests.py and 1 other location - About 2 days to fix
            dvc/testing/remote_tests.py on lines 116..140

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 252.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                @pytest.mark.xfail(raises=NotImplementedError, strict=False)
    def test_pull_00_prefix(self, tmp_dir, dvc, remote, monkeypatch):
        # Related: https://github.com/iterative/dvc/issues/6089

        fs_type = type(dvc.cloud.get_remote_odb("upstream").fs)
            Severity: Major
            Found in dvc/testing/remote_tests.py and 1 other location - About 2 days to fix
            dvc/testing/remote_tests.py on lines 142..166

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 252.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    for file in out.files:
            assert file["version_id"]
            assert file["remote"] == "upstream"
            Severity: Minor
            Found in dvc/testing/remote_tests.py and 1 other location - About 30 mins to fix
            dvc/testing/remote_tests.py on lines 320..322

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    for file in out.files:
            assert file["version_id"]
            assert file["remote"] == "upstream"
            Severity: Minor
            Found in dvc/testing/remote_tests.py and 1 other location - About 30 mins to fix
            dvc/testing/remote_tests.py on lines 227..229

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status