Sign upLogin

iterative/dvc

View on GitHub
Star
dvc/utils/collections.py

Summary

Maintainability
A
25 mins
Test Coverage

Function apply_diff has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Wontfix

def apply_diff(src, dest):  # noqa: C901
    """Recursively apply changes from src to dest.

    Preserves dest type and hidden info in dest structure,
    like ruamel.yaml leaves when parses files. This includes comments,
Severity: Minor
Found in dvc/utils/collections.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function nested_contains has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def nested_contains(dictionary: dict, phrase: str) -> bool:
    for key, val in dictionary.items():
        if key == phrase and val:
            return True
Severity: Minor
Found in dvc/utils/collections.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status