iterative/dvc

View on GitHub

Showing 149 of 260 total issues

Function upload has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def upload(self, from_infos, to_infos, names=None, no_progress_bar=False):
        names = self._verify_path_args(to_infos, from_infos, names)

        for from_info, to_info, name in zip(from_infos, to_infos, names):
            if to_info.scheme != self.scheme:
Severity: Minor
Found in dvc/remote/oss.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function upload has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def upload(self, from_infos, to_infos, names=None, no_progress_bar=False):
        names = self._verify_path_args(to_infos, from_infos, names)

        for from_info, to_info, name in zip(from_infos, to_infos, names):
            if to_info.scheme != self.scheme:
Severity: Minor
Found in dvc/remote/azure.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function reproduce has 11 arguments (exceeds 4 allowed). Consider refactoring.
Open

def reproduce(
Severity: Major
Found in dvc/repo/reproduce.py - About 1 hr to fix

    Function upload has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def upload(self, from_infos, to_infos, names=None, no_progress_bar=False):
            names = self._verify_path_args(to_infos, from_infos, names)
    
            s3 = self.s3
    
    
    Severity: Minor
    Found in dvc/remote/s3.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _walk has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def _walk(
            self,
            tree,
            topdown=True,
            ignore_file_handler=None,
    Severity: Minor
    Found in dvc/scm/git/tree.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function upload has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def upload(self, from_infos, to_infos, names=None, no_progress_bar=False):
            names = self._verify_path_args(to_infos, from_infos, names)
    
            gs = self.gs
    
    
    Severity: Minor
    Found in dvc/remote/gs.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(
    Severity: Major
    Found in dvc/stage.py - About 1 hr to fix

      Function pull has 10 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def pull(
      Severity: Major
      Found in dvc/repo/pull.py - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def __str__(self):
                if not self.url:
                    return urlunsplit((self.scheme, self.user, self.path, "", ""))
                return self.url
        Severity: Major
        Found in dvc/path/hdfs.py and 1 other location - About 1 hr to fix
        dvc/path/base.py on lines 20..23

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function used_cache has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def used_cache(
        Severity: Major
        Found in dvc/repo/__init__.py - About 1 hr to fix

          Function _load_all_used_cache has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def _load_all_used_cache(
          Severity: Major
          Found in dvc/repo/gc.py - About 1 hr to fix

            Function gc has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def gc(
            Severity: Major
            Found in dvc/repo/gc.py - About 1 hr to fix

              Function status has 9 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def status(
              Severity: Major
              Found in dvc/repo/status.py - About 1 hr to fix

                Function _reproduce has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def _reproduce(
                Severity: Major
                Found in dvc/repo/reproduce.py - About 1 hr to fix

                  Function _reproduce_stages has 9 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  def _reproduce_stages(
                  Severity: Major
                  Found in dvc/repo/reproduce.py - About 1 hr to fix

                    Function fetch has 9 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def fetch(
                    Severity: Major
                    Found in dvc/repo/fetch.py - About 1 hr to fix

                      Function push has 9 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      def push(
                      Severity: Major
                      Found in dvc/repo/push.py - About 1 hr to fix

                        Function run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def run(self):
                                msg = "this will remove all cache except the cache that is used in "
                                if not self.args.all_branches and not self.args.all_tags:
                                    msg += "the current git branch"
                                elif self.args.all_branches and not self.args.all_tags:
                        Severity: Minor
                        Found in dvc/command/gc.py - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function modify has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                        def modify(repo, path, typ=None, xpath=None, delete=False):
                            supported_types = ["raw", "json", "csv", "tsv", "hcsv", "htsv"]
                            outs = repo.find_outs_by_path(path)
                            assert len(outs) == 1
                            out = outs[0]
                        Severity: Minor
                        Found in dvc/repo/metrics/modify.py - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function walk has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def walk(self, directory, topdown=True):
                                # NOTE: original os.walk() implementation [1] with default options was
                                # used as a template.
                                #
                                # [1] https://github.com/python/cpython/blob/master/Lib/os.py
                        Severity: Minor
                        Found in dvc/remote/ssh/connection.py - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language