iterative/dvc

View on GitHub

Showing 138 of 232 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def _download(self, from_info, to_file, **_kwargs):
        bucket = self.gs.bucket(from_info.bucket)
        blob = bucket.get_blob(from_info.path)
        blob.download_to_filename(to_file)
Severity: Major
Found in dvc/remote/gs.py and 1 other location - About 1 hr to fix
dvc/remote/gs.py on lines 103..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _show has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def _show(self, target, commands, outs, locked):
        import networkx
        from dvc.stage import Stage

        stage = Stage.load(self.repo, target)
Severity: Minor
Found in dvc/command/pipeline.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function save has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def save(self):
        if not self.exists:
            raise self.DoesNotExistError(self)

        if not self.isfile and not self.isdir:
Severity: Minor
Found in dvc/output/base.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function pull has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

def pull(
Severity: Major
Found in dvc/repo/pull.py - About 1 hr to fix

    Function fspath has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def fspath(path):
            """Return the path representation of a path-like object.
    
            If str or bytes is passed in, it is returned unchanged. Otherwise the
            os.PathLike interface is used to get the path representation. If the
    Severity: Minor
    Found in dvc/utils/compat.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(
    Severity: Major
    Found in dvc/stage.py - About 1 hr to fix

      Function _load_all_used_cache has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def _load_all_used_cache(
      Severity: Major
      Found in dvc/repo/gc.py - About 1 hr to fix

        Function gc has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def gc(
        Severity: Major
        Found in dvc/repo/gc.py - About 1 hr to fix

          Function push has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def push(
          Severity: Major
          Found in dvc/repo/push.py - About 1 hr to fix

            Function status has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def status(
            Severity: Major
            Found in dvc/repo/status.py - About 1 hr to fix

              Function fetch has 9 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def fetch(
              Severity: Major
              Found in dvc/repo/fetch.py - About 1 hr to fix

                Function used_cache has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def used_cache(
                Severity: Major
                Found in dvc/repo/__init__.py - About 1 hr to fix

                  Function _merge_cache_lists has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def _merge_cache_lists(clists):
                      merged_cache = collections.defaultdict(list)
                  
                      for cache_list in clists:
                          for scheme, cache in cache_list.items():
                  Severity: Minor
                  Found in dvc/repo/gc.py - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function modify has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def modify(repo, path, typ=None, xpath=None, delete=False):
                      supported_types = ["raw", "json", "csv", "tsv", "hcsv", "htsv"]
                      outs = repo.find_outs_by_path(path)
                      assert len(outs) == 1
                      out = outs[0]
                  Severity: Minor
                  Found in dvc/repo/metrics/modify.py - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def run(self):
                          msg = "this will remove all cache except the cache that is used in "
                          if not self.args.all_branches and not self.args.all_tags:
                              msg += "the current git branch"
                          elif self.args.all_branches and not self.args.all_tags:
                  Severity: Minor
                  Found in dvc/command/gc.py - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function _process has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def _process(
                          self,
                          checksum_infos,
                          remote,
                          jobs=None,
                  Severity: Minor
                  Found in dvc/remote/local/__init__.py - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function walk has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def walk(self, directory, topdown=True):
                          # NOTE: original os.walk() implementation [1] with default options was
                          # used as a template.
                          #
                          # [1] https://github.com/python/cpython/blob/master/Lib/os.py
                  Severity: Minor
                  Found in dvc/remote/ssh/connection.py - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def run(self):
                          saved_dir = os.path.realpath(os.curdir)
                          if self.args.cwd:
                              os.chdir(self.args.cwd)
                  
                  
                  Severity: Minor
                  Found in dvc/command/repro.py - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Consider simplifying this complex logical expression.
                  Open

                          if url:
                              parsed = urlparse(url)
                              user_ssh_config = self._load_user_ssh_config(parsed.hostname)
                  
                              host = user_ssh_config.get("hostname", parsed.hostname)
                  Severity: Major
                  Found in dvc/remote/ssh/__init__.py - About 1 hr to fix

                    Function _cloud_status has 8 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def _cloud_status(
                    Severity: Major
                    Found in dvc/repo/status.py - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language