iterative/dvc

View on GitHub

Showing 142 of 234 total issues

Similar blocks of code found in 6 locations. Consider refactoring.
Open

class OutputAlreadyTrackedError(DvcException):
    def __init__(self, path):
        msg = "output '{}' is already tracked by scm (e.g. git)".format(path)
        super(OutputAlreadyTrackedError, self).__init__(msg)
Severity: Major
Found in dvc/output/base.py and 5 other locations - About 50 mins to fix
dvc/dependency/base.py on lines 6..9
dvc/dependency/base.py on lines 12..15
dvc/output/base.py on lines 17..20
dvc/output/base.py on lines 23..26
dvc/stage.py on lines 53..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

class OutputIsNotFileOrDirError(DvcException):
    def __init__(self, path):
        msg = "output '{}' is not a file or directory".format(path)
        super(OutputIsNotFileOrDirError, self).__init__(msg)
Severity: Major
Found in dvc/output/base.py and 5 other locations - About 50 mins to fix
dvc/dependency/base.py on lines 6..9
dvc/dependency/base.py on lines 12..15
dvc/output/base.py on lines 17..20
dvc/output/base.py on lines 29..32
dvc/stage.py on lines 53..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

class DependencyIsNotFileOrDirError(DvcException):
    def __init__(self, path):
        msg = "dependency '{}' is not a file or directory".format(path)
        super(DependencyIsNotFileOrDirError, self).__init__(msg)
Severity: Major
Found in dvc/dependency/base.py and 5 other locations - About 50 mins to fix
dvc/dependency/base.py on lines 6..9
dvc/output/base.py on lines 17..20
dvc/output/base.py on lines 23..26
dvc/output/base.py on lines 29..32
dvc/stage.py on lines 53..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

class OutputDoesNotExistError(DvcException):
    def __init__(self, path):
        msg = "output '{}' does not exist".format(path)
        super(OutputDoesNotExistError, self).__init__(msg)
Severity: Major
Found in dvc/output/base.py and 5 other locations - About 50 mins to fix
dvc/dependency/base.py on lines 6..9
dvc/dependency/base.py on lines 12..15
dvc/output/base.py on lines 23..26
dvc/output/base.py on lines 29..32
dvc/stage.py on lines 53..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                        if not stage.locked:
                            G_active.add_node(dep_node, stage=dep_stage)
                            G_active.add_edge(node, dep_node)

Severity: Major
Found in dvc/repo/__init__.py - About 45 mins to fix

    Function open has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def open(path, repo=None, rev=None, remote=None, mode="r", encoding=None):
    Severity: Minor
    Found in dvc/api.py - About 45 mins to fix

      Function draw has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def draw(vertexes, edges):
          """Build a DAG and draw it in ASCII.
      
          Args:
              vertexes (list): list of graph vertexes.
      Severity: Minor
      Found in dvc/dagascii.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function reproduce has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def reproduce(
      Severity: Minor
      Found in dvc/repo/reproduce.py - About 45 mins to fix

        Function _show_dependencies_tree has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def _show_dependencies_tree(self, target, commands, outs):
                from treelib import Tree
        
                nodes, edges, is_tree = self.__build_graph(target, commands, outs)
                if not nodes:
        Severity: Minor
        Found in dvc/command/pipeline.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _group has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def _group(self, checksum_infos, show_checksums=False):
                by_md5 = {}
        
                for info in checksum_infos:
                    md5 = info[self.PARAM_CHECKSUM]
        Severity: Minor
        Found in dvc/remote/local/__init__.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function list_cache_paths has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def list_cache_paths(self):
                if not self.exists(self.path_info):
                    return []
        
                files = []
        Severity: Minor
        Found in dvc/remote/hdfs.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function brancher has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def brancher(  # noqa: E302
        Severity: Minor
        Found in dvc/repo/brancher.py - About 45 mins to fix

          Function from_parts has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def from_parts(
          Severity: Minor
          Found in dvc/path_info.py - About 45 mins to fix

            Function _copy_multipart has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def _copy_multipart(
            Severity: Minor
            Found in dvc/remote/s3.py - About 45 mins to fix

              Function _collect_metrics has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def _collect_metrics(repo, path, recursive, typ, xpath, branch):
              Severity: Minor
              Found in dvc/repo/metrics/show.py - About 45 mins to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    push_parser = subparsers.add_parser(
                        "push",
                        parents=[shared_parent_parser()],
                        description=append_doc_link(PUSH_HELP, "push"),
                        help=PUSH_HELP,
                Severity: Major
                Found in dvc/command/data_sync.py and 2 other locations - About 45 mins to fix
                dvc/command/data_sync.py on lines 104..109
                dvc/command/data_sync.py on lines 197..202

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 35.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    pull_parser = subparsers.add_parser(
                        "pull",
                        parents=[shared_parent_parser()],
                        description=append_doc_link(PULL_HELP, "pull"),
                        help=PULL_HELP,
                Severity: Major
                Found in dvc/command/data_sync.py and 2 other locations - About 45 mins to fix
                dvc/command/data_sync.py on lines 154..159
                dvc/command/data_sync.py on lines 197..202

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 35.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    fetch_parser = subparsers.add_parser(
                        "fetch",
                        parents=[shared_parent_parser()],
                        description=append_doc_link(FETCH_HELP, "fetch"),
                        help=FETCH_HELP,
                Severity: Major
                Found in dvc/command/data_sync.py and 2 other locations - About 45 mins to fix
                dvc/command/data_sync.py on lines 104..109
                dvc/command/data_sync.py on lines 154..159

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 35.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 7 locations. Consider refactoring.
                Open

                    config_parser = subparsers.add_parser(
                        "config",
                        parents=[parent_config_parser, parent_parser],
                        description=append_doc_link(CONFIG_HELP, "config"),
                        help=CONFIG_HELP,
                Severity: Major
                Found in dvc/command/config.py and 6 other locations - About 40 mins to fix
                dvc/command/cache.py on lines 44..49
                dvc/command/remote.py on lines 85..90
                dvc/command/remote.py on lines 114..119
                dvc/command/remote.py on lines 134..139
                dvc/command/remote.py on lines 147..152
                dvc/command/remote.py on lines 171..176

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                class CmdRemoteConfig(CmdConfig):
                    def __init__(self, args):
                        super(CmdRemoteConfig, self).__init__(args)
                        self.remote_config = RemoteConfig(self.config)
                Severity: Minor
                Found in dvc/command/remote.py and 1 other location - About 40 mins to fix
                dvc/command/cache.py on lines 11..13

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language