lib/git-releaselog.rb
Method generate_releaselog
has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring. Open
Open
def self.generate_releaselog(options = {})
repo_path = options.fetch(:repo_path, '.')
from_ref_name = options.fetch(:from_ref, nil).strip if options.fetch(:from_ref, nil)
to_ref_name = options.fetch(:to_ref, nil).strip if options.fetch(:to_ref, nil)
scope = options.fetch(:scope, nil)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method generate_releaselog
has 78 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def self.generate_releaselog(options = {})
repo_path = options.fetch(:repo_path, '.')
from_ref_name = options.fetch(:from_ref, nil).strip if options.fetch(:from_ref, nil)
to_ref_name = options.fetch(:to_ref, nil).strip if options.fetch(:to_ref, nil)
scope = options.fetch(:scope, nil)
Consider simplifying this complex logical expression. Open
Open
if generate_complete && repo.tags.count > 0
sorted_tags = repo.tags.sort { |t1, t2| t1.target.time <=> t2.target.time }
changeLogs = []
sorted_tags.each_with_index do |tag, index|
logger.info("Tag #{tag.name} with date #{tag.target.time}")