Sign upLogin

ivan-nor/frontend-project-lvl2

View on GitHub
Star

Showing 9 of 9 total issues

Function buildInternalTree has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const buildInternalTree = (beforeData, afterData) => {
  const result = _
    .union(_.keys(beforeData), _.keys(afterData))
    .map((key) => {
      const name = key;
Severity: Minor
Found in src/builder.js - About 1 hr to fix

    Function result has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        .map((key) => {
      const name = key;
      if (_.isObject(beforeData[key]) && _.isObject(afterData[key])) {
        return {
          name,
    Severity: Minor
    Found in src/builder.js - About 1 hr to fix

      Function buildInternalTree has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      const buildInternalTree = (beforeData, afterData) => {
  const result = _
    .union(_.keys(beforeData), _.keys(afterData))
    .map((key) => {
      const name = key;
      Severity: Minor
      Found in src/builder.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function astToPlain has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const astToPlain = (ast) => {
  const iter = (tree, accName = '') => {
    const nodes = tree
      .filter(({ type }) => type !== 'unchanged')
      .map(({
      Severity: Minor
      Found in src/formatters/plain.js - About 1 hr to fix

        Function astToRecursive has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const astToRecursive = (ast) => {
  const iter = (tree, depthIndent = 1) => {
    const nodes = tree.map(({
      name, type, nextValue, prevValue, children,
    }) => {
        Severity: Minor
        Found in src/formatters/recursive.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (!_.has(afterData, name) && _.has(beforeData, name)) {
        return {
          name,
          type: 'deleted',
          nextValue: beforeData[key],
          Severity: Minor
          Found in src/builder.js and 1 other location - About 55 mins to fix
          src/builder.js on lines 29..35

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (!_.has(beforeData, name) && _.has(afterData, name)) {
        return {
          name,
          type: 'added',
          nextValue: afterData[key],
          Severity: Minor
          Found in src/builder.js and 1 other location - About 55 mins to fix
          src/builder.js on lines 22..28

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

                return {
        name,
        type: 'changed',
        nextValue: afterData[key],
        prevValue: beforeData[key],
          Severity: Major
          Found in src/builder.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                      return `${indent}  ${name}: ${stringify(nextValue, depthIndent + 2)}`;
            Severity: Major
            Found in src/formatters/recursive.js - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language