ivantsepp/codeclimate-scss-lint

View on GitHub
lib/cc/engine/scss-lint.rb

Summary

Maintainability
A
0 mins
Test Coverage

Method has too many lines. [17/10]
Open

      def scss_lint_options
        options = {
          reporters: [
            ["Codeclimate", :stdout]
          ],
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for scss_lint_options is too high. [15.94/15]
Open

      def scss_lint_options
        options = {
          reporters: [
            ["Codeclimate", :stdout]
          ],
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Line is too long. [118/80]
Open

            user_specified_scss_files = ::SCSSLint::FileFinder.new(scss_lint_config).find(scss_lint_config.scss_files)
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

File.exists? is deprecated in favor of File.exist?.
Open

        File.exists?(config_path) ? JSON.parse(File.read(config_path)) : {}
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

This cop checks for uses of the deprecated class method usages.

Example:

# bad

File.exists?(some_path)

Example:

# good

File.exist?(some_path)

Line is too long. [89/80]
Open

          if (scss_lint_config = cli.send(:setup_configuration, options)).scss_files.any?
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

            ["Codeclimate", :stdout]
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        if engine_config["config"]
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

          options[:config_file] = engine_config["config"]
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        engine_config.fetch("include_paths", ["./"])
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Unused method argument - io.
Open

      def initialize(directory:, config_path:, io: STDOUT)
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

          path.end_with?("/") || valid_extensions.include?(File.extname(path))
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [90/80]
Open

            options[:files] = filter_by_sanitized_include_paths(user_specified_scss_files)
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

The name of this source file (scss-lint.rb) should use snake_case.
Open

require 'scss_lint'
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

This cop makes sure that Ruby source files have snake_case names. Ruby scripts (i.e. source files with a shebang in the first line) are ignored.

Example:

# bad
lib/layoutManager.rb

anything/usingCamelCase

# good
lib/layout_manager.rb

anything/using_snake_case.rake

Missing top-level class documentation comment.
Open

    class SCSSLint
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        engine_config.fetch("include_paths", ["./"])
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

        if options[:files] && options[:files].count > 0
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Do not suppress exceptions.
Open

            rescue ::SCSSLint::Exceptions::NoFilesError
Severity: Minor
Found in lib/cc/engine/scss-lint.rb by rubocop

This cop checks for rescue blocks with no body.

Example:

# bad

def some_method
  do_something
rescue
  # do nothing
end

Example:

# bad

begin
  do_something
rescue
  # do nothing
end

Example:

# good

def some_method
  do_something
rescue
  handle_exception
end

Example:

# good

begin
  do_something
rescue
  handle_exception
end

There are no issues that match your filters.

Category
Status