Sign upLogin

j84reginato/my-eval

View on GitHub
Star

Showing 154 of 154 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace MyEval;
Severity: Major
Found in src/StdMathEval.php and 3 other locations - About 5 hrs to fix
src/ComplexMathEval.php on lines 1..110
src/LogicEval.php on lines 1..102
src/RationalMathEval.php on lines 1..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 187.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace MyEval;
Severity: Major
Found in src/ComplexMathEval.php and 3 other locations - About 5 hrs to fix
src/LogicEval.php on lines 1..102
src/RationalMathEval.php on lines 1..98
src/StdMathEval.php on lines 1..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 187.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace MyEval;
Severity: Major
Found in src/LogicEval.php and 3 other locations - About 5 hrs to fix
src/ComplexMathEval.php on lines 1..110
src/RationalMathEval.php on lines 1..98
src/StdMathEval.php on lines 1..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 187.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace MyEval;
Severity: Major
Found in src/RationalMathEval.php and 3 other locations - About 5 hrs to fix
src/ComplexMathEval.php on lines 1..110
src/LogicEval.php on lines 1..102
src/StdMathEval.php on lines 1..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 187.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File Parser.php has 340 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace MyEval\Parsing;
Severity: Minor
Found in src/Parsing/Parser.php - About 4 hrs to fix

    Method visitFunctionNode has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function visitFunctionNode(FunctionNode $node): Node
    {
        if ($node->operand === null) {
            throw new NullOperandException();
        }
    Severity: Major
    Found in src/Solving/Differentiator.php - About 3 hrs to fix

      Method visitFunctionNode has 87 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function visitFunctionNode(FunctionNode $node): float|int
    {
        if ($node->operand === null) {
            throw new NullOperandException();
        }
      Severity: Major
      Found in src/Solving/StdMathEvaluator.php - About 3 hrs to fix

        Function parenthesize has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
        Open

            public function parenthesize(
        ?Node $node,
        InfixExpressionNode $cutoff,
        string $prepend = '',
        bool $conservative = false
        Severity: Minor
        Found in src/Solving/ASCIIPrinter.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File RationalEvaluator.php has 278 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php

declare(strict_types=1);

namespace MyEval\Solving;
        Severity: Minor
        Found in src/Solving/RationalEvaluator.php - About 2 hrs to fix

          Method visitInfixExpressionNode has 63 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function visitInfixExpressionNode(InfixExpressionNode $node): string
    {
        $left     = $node->getLeft();
        $operator = $node->operator;
        $right    = $node->getRight();
          Severity: Major
          Found in src/Solving/ASCIIPrinter.php - About 2 hrs to fix

            Method visitFunctionNode has 63 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function visitFunctionNode(FunctionNode $node): Complex
    {
        if ($node->operand === null) {
            throw new NullOperandException();
        }
            Severity: Major
            Found in src/Solving/ComplexEvaluator.php - About 2 hrs to fix

              Method visitInfixExpressionNode has 63 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function visitInfixExpressionNode(InfixExpressionNode $node): Node
    {
        $left     = $node->getLeft();
        $operator = $node->operator;
        $right    = $node->getRight();
              Severity: Major
              Found in src/Solving/Differentiator.php - About 2 hrs to fix

                Parser has 23 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class Parser
{
    use Numeric;

    /**
                Severity: Minor
                Found in src/Parsing/Parser.php - About 2 hrs to fix

                  Function parenthesize has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function parenthesize(
        Node $node,
        InfixExpressionNode $cutoff,
        string $prepend = '',
        bool $conservative = false
                  Severity: Minor
                  Found in src/Solving/LaTeXPrinter.php - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method processToken has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private function processToken(Token $token): void
    {
        $node = Node::factory($token);

        switch (get_class($node)) {
                  Severity: Minor
                  Found in src/Parsing/Parser.php - About 2 hrs to fix

                    Method visitFunctionNode has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function visitFunctionNode(FunctionNode $node): RationalNode
    {
        if ($node->operand === null) {
            throw new NullOperandException();
        }
                    Severity: Minor
                    Found in src/Solving/RationalEvaluator.php - About 1 hr to fix

                      Method __construct has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function __construct()
    {
        $this->add(new TokenDefinition('/\d+[,\.]\d+(e[+-]?\d+)?/', TokenType::REAL_NUMBER));

        $this->add(new TokenDefinition('/\d+/', TokenType::NATURAL_NUMBER));
                      Severity: Minor
                      Found in src/Lexing/AbstractLexer.php - About 1 hr to fix

                        Function ifactor has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public static function ifactor($n): array
    {

        // max_n = 2^31-1 = 2147483647
        $d       = 2;
                        Severity: Minor
                        Found in src/Solving/RationalEvaluator.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function visitInfixExpressionNode has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function visitInfixExpressionNode(InfixExpressionNode $node): float
    {
        $left     = $node->getLeft();
        $operator = $node->operator;
        $right    = $node->getRight();
                        Severity: Minor
                        Found in src/Solving/StdMathEvaluator.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method visitInfixExpressionNode has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function visitInfixExpressionNode(InfixExpressionNode $node): string
    {
        $left     = $node->getLeft();
        $operator = $node->operator;
        $right    = $node->getRight();
                        Severity: Minor
                        Found in src/Solving/LaTeXPrinter.php - About 1 hr to fix
                          Severity
                          Category
                          Status
                          Source
                          Language