j84reginato/my-eval

View on GitHub

Showing 154 of 154 total issues

Function visitFunctionNode has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function visitFunctionNode(FunctionNode $node): Node
    {
        if ($node->operand === null) {
            throw new NullOperandException();
        }
Severity: Minor
Found in src/Solving/Differentiator.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processToken has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    private function processToken(Token $token): void
    {
        $node = Node::factory($token);

        switch (get_class($node)) {
Severity: Minor
Found in src/Parsing/Parser.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method visitTernaryNode has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function visitTernaryNode(TernaryExpressionNode $node): float
    {
        /** @var InfixExpressionNode|BooleanNode $condition */
        $condition = $node->getCondition();

Severity: Minor
Found in src/Solving/LogicEvaluator.php - About 1 hr to fix

    Method visitInfixExpressionNode has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function visitInfixExpressionNode(InfixExpressionNode $node): float
        {
            $left     = $node->getLeft();
            $operator = $node->operator;
            $right    = $node->getRight();
    Severity: Minor
    Found in src/Solving/StdMathEvaluator.php - About 1 hr to fix

      Method visitInfixExpressionNode has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function visitInfixExpressionNode(InfixExpressionNode $node)
          {
              $left     = $node->getLeft();
              $operator = $node->operator;
              $right    = $node->getRight();
      Severity: Minor
      Found in src/Solving/RationalEvaluator.php - About 1 hr to fix

        Method ifactor has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function ifactor($n): array
            {
        
                // max_n = 2^31-1 = 2147483647
                $d       = 2;
        Severity: Minor
        Found in src/Solving/RationalEvaluator.php - About 1 hr to fix

          Method factory has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function factory(Token $token): Node
              {
                  return match ($token->type) {
                      // Operands
                      TokenType::NATURAL_NUMBER,
          Severity: Minor
          Found in src/Parsing/Nodes/Node.php - About 1 hr to fix

            Method visitFunctionNode has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function visitFunctionNode(FunctionNode $node): string
                {
                    $functionName = $node->operator;
            
                    $operand = $node->operand->accept($this);
            Severity: Minor
            Found in src/Solving/LaTeXPrinter.php - About 1 hr to fix

              Method parenthesize has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function parenthesize(
                      ?Node $node,
                      InfixExpressionNode $cutoff,
                      string $prepend = '',
                      bool $conservative = false
              Severity: Minor
              Found in src/Solving/ASCIIPrinter.php - About 1 hr to fix

                Method fromFloat has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public static function fromFloat(float|string $float, float $tolerance = 1e-7): Rational
                    {
                        if (is_string($float) && preg_match('~^-?\d+([,|.]\d+)?$~', $float)) {
                            $float = (float)str_replace(',', '.', $float);
                        }
                Severity: Minor
                Found in src/Extensions/Rational.php - About 1 hr to fix

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                  if (!function_exists('tree_printer')) {
                      function tree_printer(string $expression)
                      {
                          $eval        = new StdMathEval();
                          $treePrinter = new TreePrinter();
                  Severity: Major
                  Found in examples/functions.php and 2 other locations - About 1 hr to fix
                  examples/functions.php on lines 93..109
                  examples/functions.php on lines 111..127

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 103.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                  if (!function_exists('latex_printer')) {
                      function latex_printer(string $expression)
                      {
                          $eval         = new StdMathEval();
                          $laTeXPrinter = new LaTeXPrinter();
                  Severity: Major
                  Found in examples/functions.php and 2 other locations - About 1 hr to fix
                  examples/functions.php on lines 75..91
                  examples/functions.php on lines 111..127

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 103.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                  if (!function_exists('ascii_printer')) {
                      function ascii_printer(string $expression)
                      {
                          $eval        = new StdMathEval();
                          $treePrinter = new ASCIIPrinter();
                  Severity: Major
                  Found in examples/functions.php and 2 other locations - About 1 hr to fix
                  examples/functions.php on lines 75..91
                  examples/functions.php on lines 93..109

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 103.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method parse has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public static function parse(string|Rational $value, bool $normalize = true): Rational
                      {
                          if ($value === '') {
                              throw new SyntaxErrorException();
                          }
                  Severity: Minor
                  Found in src/Extensions/Rational.php - About 1 hr to fix

                    Method compareTo has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function compareTo(Node $other): bool
                        {
                            if (!($other instanceof static)) {
                                return false;
                            }
                    Severity: Minor
                    Found in src/Parsing/Nodes/Operator/AbstractExpressionNode.php - About 1 hr to fix

                      Method rpow has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private function rpow($a, $b)
                          {
                              if ($b->getDenominator() === 1) {
                                  $n = $b->getNumerator();
                                  if ($n >= 0) {
                      Severity: Minor
                      Found in src/Solving/RationalEvaluator.php - About 1 hr to fix

                        Function visitTernaryNode has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function visitTernaryNode(TernaryExpressionNode $node): float
                            {
                                /** @var InfixExpressionNode|BooleanNode $condition */
                                $condition = $node->getCondition();
                        
                        
                        Severity: Minor
                        Found in src/Solving/LogicEvaluator.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method complexity has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function complexity(): int
                            {
                                switch (\get_class($this)) {
                                    case IntegerNode::class:
                                    case VariableNode::class:
                        Severity: Minor
                        Found in src/Parsing/Nodes/Node.php - About 1 hr to fix

                          Function numericFactors has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                          Open

                              private function numericFactors(Node $leftOperand, Node $rightOperand): ?Node
                              {
                                  if (
                                      ($this->isNumeric($leftOperand) && (float)$leftOperand->value === 0.0) ||
                                      ($this->isNumeric($rightOperand) && (float)$rightOperand->value === 0.0)
                          Severity: Minor
                          Found in src/Parsing/Operations/Math/MultiplicationOperation.php - About 55 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function visitInfixExpressionNode has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function visitInfixExpressionNode(InfixExpressionNode $node): Node
                              {
                                  $left     = $node->getLeft();
                                  $operator = $node->operator;
                                  $right    = $node->getRight();
                          Severity: Minor
                          Found in src/Solving/Differentiator.php - About 55 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language