j84reginato/my-eval

View on GitHub
src/Solving/Differentiator.php

Summary

Maintainability
D
1 day
Test Coverage

Method visitFunctionNode has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function visitFunctionNode(FunctionNode $node): Node
    {
        if ($node->operand === null) {
            throw new NullOperandException();
        }
Severity: Major
Found in src/Solving/Differentiator.php - About 3 hrs to fix

    Method visitInfixExpressionNode has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function visitInfixExpressionNode(InfixExpressionNode $node): Node
        {
            $left     = $node->getLeft();
            $operator = $node->operator;
            $right    = $node->getRight();
    Severity: Major
    Found in src/Solving/Differentiator.php - About 2 hrs to fix

      Function visitFunctionNode has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function visitFunctionNode(FunctionNode $node): Node
          {
              if ($node->operand === null) {
                  throw new NullOperandException();
              }
      Severity: Minor
      Found in src/Solving/Differentiator.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function visitInfixExpressionNode has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function visitInfixExpressionNode(InfixExpressionNode $node): Node
          {
              $left     = $node->getLeft();
              $operator = $node->operator;
              $right    = $node->getRight();
      Severity: Minor
      Found in src/Solving/Differentiator.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                          return $this->nodeFactory->multiplication($right->accept($this), $node);
      Severity: Major
      Found in src/Solving/Differentiator.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this->nodeFactory->division($inner, new FunctionNode('sqrt', $temp));
        Severity: Major
        Found in src/Solving/Differentiator.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return $this->nodeFactory->multiplication(
                                  new IntegerNode($exponent->value),
                                  $this->nodeFactory->multiplication($fpow, $base->accept($this))
                              );
          Severity: Major
          Found in src/Solving/Differentiator.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $this->nodeFactory->multiplication($node, $factor2);
            Severity: Major
            Found in src/Solving/Differentiator.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $this->nodeFactory->division($inner, $denom);
              Severity: Major
              Found in src/Solving/Differentiator.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return $this->nodeFactory->division($inner, $denominator);
                Severity: Major
                Found in src/Solving/Differentiator.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return $this->nodeFactory->division($inner, new FunctionNode('sqrt', $temp));
                  Severity: Major
                  Found in src/Solving/Differentiator.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return $this->nodeFactory->division($inner, $denominator);
                    Severity: Major
                    Found in src/Solving/Differentiator.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return $this->nodeFactory->multiplication($inner, $df);
                      Severity: Major
                      Found in src/Solving/Differentiator.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return $this->nodeFactory->multiplication(
                                                new FloatNode($exponent->value),
                                                $this->nodeFactory->multiplication($fpow, $base->accept($this))
                                            );
                        Severity: Major
                        Found in src/Solving/Differentiator.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                              return $this->nodeFactory->multiplication(
                                                  $exponent,
                                                  $this->nodeFactory->multiplication($fpow, $base->accept($this))
                                              );
                          Severity: Major
                          Found in src/Solving/Differentiator.php - About 30 mins to fix

                            There are no issues that match your filters.

                            Category
                            Status