Sign upLogin

jamesrwhite/minicron

View on GitHub
Star
client/api/api.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method client.post has 64 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *client) post(method string, reqBody interface{}, respStruct interface{}) (interface{}, error) {
    // Get the api base endpoint
    apiBase := viper.Get("apiBase")

    // Build the URL for the request
Severity: Minor
Found in client/api/api.go - About 1 hr to fix

    Method client.post has 6 return statements (exceeds 4 allowed).
    Open

    func (c *client) post(method string, reqBody interface{}, respStruct interface{}) (interface{}, error) {
    // Get the api base endpoint
    apiBase := viper.Get("apiBase")

    // Build the URL for the request
    Severity: Major
    Found in client/api/api.go - About 40 mins to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      func (c *client) Init(req *InitRequest) (*InitResponse, error) {
    response, err := c.post("/execution/init", req, &InitResponse{})
    initResponse := response.(*InitResponse)

    if err != nil {
      Severity: Major
      Found in client/api/api.go and 4 other locations - About 50 mins to fix
      client/api/api.go on lines 108..121
      client/api/api.go on lines 123..136
      client/api/api.go on lines 138..151
      client/api/api.go on lines 153..166

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 122.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      func (c *client) Finish(req *FinishRequest) (*FinishResponse, error) {
    response, err := c.post("/execution/finish", req, &FinishResponse{})
    finishResponse := response.(*FinishResponse)

    if err != nil {
      Severity: Major
      Found in client/api/api.go and 4 other locations - About 50 mins to fix
      client/api/api.go on lines 93..106
      client/api/api.go on lines 108..121
      client/api/api.go on lines 123..136
      client/api/api.go on lines 153..166

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 122.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      func (c *client) Start(req *StartRequest) (*StartResponse, error) {
    response, err := c.post("/execution/start", req, &StartResponse{})
    startResponse := response.(*StartResponse)

    if err != nil {
      Severity: Major
      Found in client/api/api.go and 4 other locations - About 50 mins to fix
      client/api/api.go on lines 93..106
      client/api/api.go on lines 123..136
      client/api/api.go on lines 138..151
      client/api/api.go on lines 153..166

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 122.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      func (c *client) Output(req *OutputRequest) (*OutputResponse, error) {
    response, err := c.post("/execution/output", req, &OutputResponse{})
    outputResponse := response.(*OutputResponse)

    if err != nil {
      Severity: Major
      Found in client/api/api.go and 4 other locations - About 50 mins to fix
      client/api/api.go on lines 93..106
      client/api/api.go on lines 108..121
      client/api/api.go on lines 138..151
      client/api/api.go on lines 153..166

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 122.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      func (c *client) Exit(req *ExitRequest) (*ExitResponse, error) {
    response, err := c.post("/execution/exit", req, &ExitResponse{})
    exitResponse := response.(*ExitResponse)

    if err != nil {
      Severity: Major
      Found in client/api/api.go and 4 other locations - About 50 mins to fix
      client/api/api.go on lines 93..106
      client/api/api.go on lines 108..121
      client/api/api.go on lines 123..136
      client/api/api.go on lines 138..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 122.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status