Sign upLogin

jameswlane/jest-express

View on GitHub
Star

Showing 17 of 17 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  public setSignedCookies(
    key: string | { [key: string]: string },
    value?: string,
  ) {
    if (typeof key === 'string') {
Severity: Major
Found in src/request.ts and 4 other locations - About 3 hrs to fix
src/request.ts on lines 208..216
src/request.ts on lines 252..260
src/request.ts on lines 270..278
src/request.ts on lines 280..288

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  public setRoute(key: string | { [key: string]: string }, value?: string) {
    if (typeof key === 'string') {
      this.route[key] = value;
    } else {
      for (const k of Object.keys(key)) {
Severity: Major
Found in src/request.ts and 4 other locations - About 3 hrs to fix
src/request.ts on lines 208..216
src/request.ts on lines 252..260
src/request.ts on lines 270..278
src/request.ts on lines 294..305

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  public setCookies(key: string | { [key: string]: string }, value?: string) {
    if (typeof key === 'string') {
      this.cookies[key] = value;
    } else {
      for (const k of Object.keys(key)) {
Severity: Major
Found in src/request.ts and 4 other locations - About 3 hrs to fix
src/request.ts on lines 252..260
src/request.ts on lines 270..278
src/request.ts on lines 280..288
src/request.ts on lines 294..305

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  public setQuery(key: string | { [key: string]: string }, value?: string) {
    if (typeof key === 'string') {
      this.query[key] = value;
    } else {
      for (const k of Object.keys(key)) {
Severity: Major
Found in src/request.ts and 4 other locations - About 3 hrs to fix
src/request.ts on lines 208..216
src/request.ts on lines 252..260
src/request.ts on lines 280..288
src/request.ts on lines 294..305

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  public setParams(key: string | { [key: string]: string }, value?: string) {
    if (typeof key === 'string') {
      this.params[key] = value;
    } else {
      for (const k of Object.keys(key)) {
Severity: Major
Found in src/request.ts and 4 other locations - About 3 hrs to fix
src/request.ts on lines 208..216
src/request.ts on lines 270..278
src/request.ts on lines 280..288
src/request.ts on lines 294..305

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function constructor has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor() {
    // Properties
    this.headers = {};
    this.headersSent = false;
    this.locals = {};
Severity: Major
Found in src/response.ts - About 2 hrs to fix

    Request has 23 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export class Request {
  // Properties
  public baseUrl: string;

  public body: any;
    Severity: Minor
    Found in src/request.ts - About 2 hrs to fix

      Function constructor has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor() {
    this.request = new Request(null, { app: this });
    this.response = new Response();
    this.next = next;
    // Properties
      Severity: Major
      Found in src/express.ts - About 2 hrs to fix

        Function constructor has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          constructor() {
    const handler = (path: any, ...callbacks: any): void => {
      const flattened = [].concat(...callbacks); // flatten array
      if (typeof path === 'string' && flattened.every((cb: any) => typeof cb === 'function')) {
        flattened.forEach((cb: any) => cb(this.request, this.response, this.next));
        Severity: Minor
        Found in src/router.ts - About 1 hr to fix

          Function constructor has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

            constructor() {
    this.request = new Request(null, { app: this });
    this.response = new Response();
    this.next = next;
    // Properties
          Severity: Minor
          Found in src/express.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function constructor has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            constructor(url?: string | null, options?: IRequestOptions) {
    // Properties
    this.baseUrl = '';
    this.body = '';
    this.cookies = {};
          Severity: Minor
          Found in src/request.ts - About 1 hr to fix

            Function constructor has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

              constructor() {
    // Properties
    this.headers = {};
    this.headersSent = false;
    this.locals = {};
            Severity: Minor
            Found in src/response.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function setUrl has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              public setUrl(url: string, options?: IRequestOptions) {
    const parsedUrl = parse(url, true);

    this.path = parsedUrl.pathname || '/';
    this.hostname = parsedUrl.hostname || '';
            Severity: Minor
            Found in src/request.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function resetMocked has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              public resetMocked() {
    // Properties
    this.baseUrl = '';
    this.body = '';
    this.cookies = {};
            Severity: Minor
            Found in src/request.ts - About 1 hr to fix

              Function resetMocked has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                public resetMocked() {
    // Properties
    this.locals = {};
    this.error = {};
    this.mountpath = '';
              Severity: Minor
              Found in src/express.ts - About 1 hr to fix

                Function resetMocked has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  public resetMocked() {
    // Properties
    this.headers = {};
    this.headersSent = false;
    this.locals = {};
                Severity: Minor
                Found in src/response.ts - About 1 hr to fix

                  Function setUrl has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    public setUrl(url: string, options?: IRequestOptions) {
    const parsedUrl = parse(url, true);

    this.path = parsedUrl.pathname || '/';
    this.hostname = parsedUrl.hostname || '';
                  Severity: Minor
                  Found in src/request.ts - About 1 hr to fix
                    Severity
                    Category
                    Status
                    Source
                    Language