janekolszak/idp

Method Challenge.GrantAccessToAll has 5 return statements (exceeds 4 allowed).

Open

func (c *Challenge) GrantAccessToAll(w http.ResponseWriter, r *http.Request) error {
    now := time.Now()

    token := jwt.New(jwt.SigningMethodRS256)

2: cannot find package "github.com/dgrijalva/jwt-go" in any of:

Open

    jwt "github.com/dgrijalva/jwt-go"

• Exclude checks
  • Disable engine
  • Disable check

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (c *Challenge) Update(w http.ResponseWriter, r *http.Request) error {
    session, err := c.idp.config.ChallengeStore.Get(r, SessionCookieName)
    if err != nil {
        return err
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (c *Challenge) Save(w http.ResponseWriter, r *http.Request) error {
    session, err := c.idp.config.ChallengeStore.New(r, SessionCookieName)
    if err != nil {
        return err
    }

• Read up
  Read up

package comment should be of the form "Package idp ..."

Open

// Package for handling challenge requests from Hydra(https://github.com/ory/hydra).

• Exclude checks
  • Disable engine
  • Disable check

exported const SessionCookieName should have comment (or a comment on this block) or be unexported

Open

    SessionCookieName = "challenge"

• Exclude checks
  • Disable engine
  • Disable check

comment on exported method Challenge.Save should be of the form "Save ..."

Open

// Saves the Challenge to it's session store

• Exclude checks
  • Disable engine
  • Disable check

comment on exported method Challenge.RefuseAccess should be of the form "RefuseAccess ..."

Open

// User refused access to requested scopes, forward the desicion to Hydra via redirection.

• Exclude checks
  • Disable engine
  • Disable check

exported type Challenge should have comment or be unexported

Open

type Challenge struct {

• Exclude checks
  • Disable engine
  • Disable check

comment on exported method Challenge.Delete should be of the form "Delete ..."

Open

// Deletes the challenge from the store

• Exclude checks
  • Disable engine
  • Disable check

comment on exported method Challenge.GrantAccessToAll should be of the form "GrantAccessToAll ..."

Open

// User granted access to requested scopes, forward the desicion to Hydra via redirection.

• Exclude checks
  • Disable engine
  • Disable check