janekolszak/idp

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (c *Challenge) Update(w http.ResponseWriter, r *http.Request) error {
    session, err := c.idp.config.ChallengeStore.Get(r, SessionCookieName)
    if err != nil {
        return err
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (c *Challenge) Save(w http.ResponseWriter, r *http.Request) error {
    session, err := c.idp.config.ChallengeStore.New(r, SessionCookieName)
    if err != nil {
        return err
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (idp *IDP) downloadVerificationKey() (*rsa.PublicKey, error) {

    jwk, err := idp.hc.JSONWebKeys.GetKey(hoauth2.ConsentChallengeKey, "public")
    if err != nil {
        return nil, err

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (idp *IDP) downloadConsentKey() (*rsa.PrivateKey, error) {
    jwk, err := idp.hc.JSONWebKeys.GetKey(hoauth2.ConsentEndpointKey, "private")
    if err != nil {
        return nil, err
    }

• Read up
  Read up

Method IDP.NewChallenge has 5 return statements (exceeds 4 allowed).

Open

func (idp *IDP) NewChallenge(ctx context.Context, r *http.Request, user string) (challenge *Challenge, err error) {
    tokenStr := r.FormValue("challenge")
    if tokenStr == "" {
        // No challenge token
        err = ErrorBadRequest

Method IDP.getChallengeToken has 5 return statements (exceeds 4 allowed).

Open

func (idp *IDP) getChallengeToken(challengeString string) (*jwt.Token, error) {
    token, err := jwt.Parse(challengeString, func(token *jwt.Token) (interface{}, error) {
        _, ok := token.Method.(*jwt.SigningMethodRSA)
        if !ok {
            return nil, ErrorBadSigningMethod

Method Challenge.GrantAccessToAll has 5 return statements (exceeds 4 allowed).

Open

func (c *Challenge) GrantAccessToAll(w http.ResponseWriter, r *http.Request) error {
    now := time.Now()

    token := jwt.New(jwt.SigningMethodRS256)

exported var ErrorBadPublicKey should have comment or be unexported

Open

    ErrorBadPublicKey       = errors.New("cannot convert to public key")

• Exclude checks
  • Disable engine
  • Disable check

exported const VerifyPublicKey should have comment (or a comment on this block) or be unexported

Open

    VerifyPublicKey   = "VerifyPublic"

• Exclude checks
  • Disable engine
  • Disable check

package comment should be of the form "Package idp ..."

Open

// Package for handling challenge requests from Hydra(https://github.com/ory/hydra).

• Exclude checks
  • Disable engine
  • Disable check

comment on exported method IDP.Close should be of the form "Close ..."

Open

// Closes connection to Hydra, cleans cache etc.

• Exclude checks
  • Disable engine
  • Disable check

exported const SessionCookieName should have comment (or a comment on this block) or be unexported

Open

    SessionCookieName = "challenge"

• Exclude checks
  • Disable engine
  • Disable check

comment on exported type IDP should be of the form "IDP ..." (with optional leading article)

Open

// Identity Provider helper

• Exclude checks
  • Disable engine
  • Disable check

comment on exported method Challenge.Save should be of the form "Save ..."

Open

// Saves the Challenge to it's session store

• Exclude checks
  • Disable engine
  • Disable check

exported function ClientInfoKey should have comment or be unexported

Open

func ClientInfoKey(clientID string) string {

• Exclude checks
  • Disable engine
  • Disable check

comment on exported method Challenge.RefuseAccess should be of the form "RefuseAccess ..."

Open

// User refused access to requested scopes, forward the desicion to Hydra via redirection.

• Exclude checks
  • Disable engine
  • Disable check

type name will be used as idp.IDPConfig by other packages, and that stutters; consider calling this Config

Open

type IDPConfig struct {

• Exclude checks
  • Disable engine
  • Disable check

2: cannot find package "github.com/dgrijalva/jwt-go" in any of:

Open

    jwt "github.com/dgrijalva/jwt-go"

• Exclude checks
  • Disable engine
  • Disable check

exported type Challenge should have comment or be unexported

Open

type Challenge struct {

• Exclude checks
  • Disable engine
  • Disable check

comment on exported method IDP.NewChallenge should be of the form "NewChallenge ..."

Open

// Create a new Challenge. The request will contain all the necessary information from Hydra, passed in the URL.

• Exclude checks
  • Disable engine
  • Disable check