Sign upLogin

jaredhanson/oauth2orize-redelegate

View on GitHub
Star

Showing 3 of 3 total issues

Function exports has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function(options, issue) {
  if (typeof options == 'function') {
    issue = options;
    options = undefined;
  }
Severity: Minor
Found in lib/exchange/redelegate.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(options, issue) {
  if (typeof options == 'function') {
    issue = options;
    options = undefined;
  }
Severity: Major
Found in lib/exchange/redelegate.js - About 2 hrs to fix

    Function redelegate has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      return function redelegate(req, res, next) {
    if (!req.body) { return next(new Error('OAuth2orize requires body parsing. Did you forget app.use(express.bodyParser())?')); }
    
    // The 'user' property of `req` holds the authenticated user.  In the case
    // of the token endpoint, the property will contain the OAuth 2.0 client.
    Severity: Minor
    Found in lib/exchange/redelegate.js - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language