jaredhanson/oauth2orize

View on GitHub

Showing 87 of 87 total issues

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    if (scope) {
      if (typeof scope !== 'string') {
        return next(new TokenError('Invalid parameter: scope must be a string', 'invalid_request'));
      }

Severity: Major
Found in lib/exchange/password.js and 2 other locations - About 5 hrs to fix
lib/exchange/clientCredentials.js on lines 86..101
lib/exchange/refreshToken.js on lines 87..102

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 138.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    if (scope) {
      if (typeof scope !== 'string') {
        return next(new TokenError('Invalid parameter: scope must be a string', 'invalid_request'));
      }

Severity: Major
Found in lib/exchange/refreshToken.js and 2 other locations - About 5 hrs to fix
lib/exchange/clientCredentials.js on lines 86..101
lib/exchange/password.js on lines 92..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 138.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function token has 121 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function token(options, issue) {
  if (typeof options == 'function') {
    issue = options;
    options = undefined;
  }
Severity: Major
Found in lib/grant/token.js - About 4 hrs to fix

    Function code has 118 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function code(options, issue) {
      if (typeof options == 'function') {
        issue = options;
        options = undefined;
      }
    Severity: Major
    Found in lib/grant/code.js - About 4 hrs to fix

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

            res.end = function(chunk, encoding) {
              if (server._txnStore.legacy == true) {
                server._txnStore.remove(options, req, req.oauth2.transactionID, function noop(){});
              } else {
                server._txnStore.remove(req, req.oauth2.transactionID, function noop(){});
      Severity: Major
      Found in lib/middleware/authorizationErrorHandler.js and 2 other locations - About 4 hrs to fix
      lib/middleware/decision.js on lines 105..114
      lib/middleware/resume.js on lines 42..51

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 129.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

            res.end = function(chunk, encoding) {
              if (server._txnStore.legacy == true) {
                server._txnStore.remove(options, req, req.oauth2.transactionID, function noop(){});
              } else {
                server._txnStore.remove(req, req.oauth2.transactionID, function noop(){});
      Severity: Major
      Found in lib/middleware/decision.js and 2 other locations - About 4 hrs to fix
      lib/middleware/authorizationErrorHandler.js on lines 12..21
      lib/middleware/resume.js on lines 42..51

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 129.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

              res.end = function(chunk, encoding) {
                if (server._txnStore.legacy == true) {
                  server._txnStore.remove(options, req, req.oauth2.transactionID, function noop(){});
                } else {
                  server._txnStore.remove(req, req.oauth2.transactionID, function noop(){});
      Severity: Major
      Found in lib/middleware/resume.js and 2 other locations - About 4 hrs to fix
      lib/middleware/authorizationErrorHandler.js on lines 12..21
      lib/middleware/decision.js on lines 105..114

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 129.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function exports has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function(options, issue) {
        if (typeof options == 'function') {
          issue = options;
          options = undefined;
        }
      Severity: Minor
      Found in lib/exchange/authorizationCode.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exports has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function(server, options, parse, complete) {
        if (typeof options == 'function') {
          complete = parse;
          parse = options;
          options = undefined;
      Severity: Minor
      Found in lib/middleware/decision.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exports has 101 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(server, options, validate, immediate, complete) {
        if (typeof options == 'function') {
          complete = immediate;
          immediate = validate;
          validate = options;
      Severity: Major
      Found in lib/middleware/authorization.js - About 4 hrs to fix

        Function grant has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
        Open

        Server.prototype.grant = function(type, phase, fn) {
          if (typeof type == 'object') {
            // sig: grant(mod)
            var mod = type;
            if (mod.request) { this.grant(mod.name, 'request', mod.request); }
        Severity: Minor
        Found in lib/server.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function authorization has 88 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          return function authorization(req, res, next) {
            
            var body = req.body || {}
              , type = req.query.response_type || body.response_type;
        
        
        Severity: Major
        Found in lib/middleware/authorization.js - About 3 hrs to fix

          Function exports has 87 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function(server, options, immediate, complete) {
            if (typeof options == 'function') {
              complete = immediate;
              immediate = options;
              options = undefined;
          Severity: Major
          Found in lib/middleware/resume.js - About 3 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            fs.readdirSync(__dirname + '/grant').forEach(function(filename) {
              if (/\.js$/.test(filename)) {
                var name = path.basename(filename, '.js');
                var load = function () { return require('./grant/' + name); };
                exports.grant.__defineGetter__(name, load);
            Severity: Major
            Found in lib/index.js and 1 other location - About 3 hrs to fix
            lib/index.js on lines 56..62

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 101.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            fs.readdirSync(__dirname + '/exchange').forEach(function(filename) {
              if (/\.js$/.test(filename)) {
                var name = path.basename(filename, '.js');
                var load = function () { return require('./exchange/' + name); };
                exports.exchange.__defineGetter__(name, load);
            Severity: Major
            Found in lib/index.js and 1 other location - About 3 hrs to fix
            lib/index.js on lines 39..45

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 101.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function resume has 76 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              return function resume(req, res, next) {
                if (!req.oauth2) { return next(new Error('OAuth2orize requires transaction support. Did you forget oauth2orize.transactionLoader(...)?')); }
                
                req.oauth2.user = req[userProperty];
                if (res.locals) {
            Severity: Major
            Found in lib/middleware/resume.js - About 3 hrs to fix

              Function validated has 65 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    function validated(err, client, redirectURI, webOrigin) {
                      // Set properties *before* next()'ing due to error.  The presence of a
                      // redirectURI being provided, even under error conditions, indicates
                      // that the client should be informed of the error via a redirect.
                      req.oauth2 = {};
              Severity: Major
              Found in lib/middleware/authorization.js - About 2 hrs to fix

                Function exports has 65 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                module.exports = function(options, issue) {
                  if (typeof options == 'function') {
                    issue = options;
                    options = undefined;
                  }
                Severity: Major
                Found in lib/exchange/password.js - About 2 hrs to fix

                  Function exports has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  module.exports = function(options, issue) {
                    if (typeof options == 'function') {
                      issue = options;
                      options = undefined;
                    }
                  Severity: Major
                  Found in lib/exchange/refreshToken.js - About 2 hrs to fix

                    Function exports has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    module.exports = function(options, issue) {
                      if (typeof options == 'function') {
                        issue = options;
                        options = undefined;
                      }
                    Severity: Major
                    Found in lib/exchange/clientCredentials.js - About 2 hrs to fix
                      Severity
                      Category
                      Status
                      Source
                      Language