jaredhanson/oauth2orize

View on GitHub

Showing 87 of 87 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    if (!txn.res.allow) {
      var params = { error: 'access_denied' };
      if (txn.req && txn.req.state) { params.state = txn.req.state; }
      return respond(txn, res, params);
    }
Severity: Major
Found in lib/grant/code.js and 1 other location - About 2 hrs to fix
lib/grant/token.js on lines 150..154

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    if (!txn.res.allow) {
      var params = { error: 'access_denied' };
      if (txn.req && txn.req.state) { params.state = txn.req.state; }
      return respond(txn, res, params);
    }
Severity: Major
Found in lib/grant/token.js and 1 other location - About 2 hrs to fix
lib/grant/code.js on lines 150..154

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function password has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  return function password(req, res, next) {
    if (!req.body) { return next(new Error('OAuth2orize requires body parsing. Did you forget app.use(express.bodyParser())?')); }
    
    // The 'user' property of `req` holds the authenticated user.  In the case
    // of the token endpoint, the property will contain the OAuth 2.0 client.
Severity: Major
Found in lib/exchange/password.js - About 2 hrs to fix

    File server.js has 251 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     * Module dependencies.
     */
    var SessionStore = require('./txn/session')
      , UnorderedList = require('./unorderedlist')
    Severity: Minor
    Found in lib/server.js - About 2 hrs to fix

      Function immediated has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function immediated(err, allow, info, locals) {
            if (err) { return next(err); }
            if (allow) {
              req.oauth2.res = info || {};
              req.oauth2.res.allow = true;
      Severity: Minor
      Found in lib/middleware/resume.js - About 2 hrs to fix

        Function refresh_token has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          return function refresh_token(req, res, next) {
            if (!req.body) { return next(new Error('OAuth2orize requires body parsing. Did you forget app.use(express.bodyParser())?')); }
            
            // The 'user' property of `req` holds the authenticated user.  In the case
            // of the token endpoint, the property will contain the OAuth 2.0 client.
        Severity: Minor
        Found in lib/exchange/refreshToken.js - About 2 hrs to fix

          Function response has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function response(txn, res, complete, next) {
              var mode = 'fragment'
                , respond;
              if (txn.req && txn.req.responseMode) {
                mode = txn.req.responseMode;
          Severity: Minor
          Found in lib/grant/token.js - About 1 hr to fix

            Function client_credentials has 48 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              return function client_credentials(req, res, next) {
                if (!req.body) { return next(new Error('OAuth2orize requires body parsing. Did you forget app.use(express.bodyParser())?')); }
                
                // The 'user' property of `req` holds the authenticated user.  In the case
                // of the token endpoint, the property will contain the OAuth 2.0 client.
            Severity: Minor
            Found in lib/exchange/clientCredentials.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              function ForbiddenError(message) {
                Error.call(this);
                Error.captureStackTrace(this, arguments.callee);
                this.name = 'ForbiddenError';
                this.message = message;
              Severity: Major
              Found in lib/errors/forbiddenerror.js and 1 other location - About 1 hr to fix
              lib/errors/badrequesterror.js on lines 6..12

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 73.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              function BadRequestError(message) {
                Error.call(this);
                Error.captureStackTrace(this, arguments.callee);
                this.name = 'BadRequestError';
                this.message = message;
              Severity: Major
              Found in lib/errors/badrequesterror.js and 1 other location - About 1 hr to fix
              lib/errors/forbiddenerror.js on lines 6..12

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 73.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function exports has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = function(server, options, parse, complete) {
                if (typeof options == 'function') {
                  complete = parse;
                  parse = options;
                  options = undefined;
              Severity: Minor
              Found in lib/middleware/decision.js - About 1 hr to fix

                Function response has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  function response(txn, res, complete, next) {
                    var mode = 'query'
                      , respond;
                    if (txn.req && txn.req.responseMode) {
                      mode = txn.req.responseMode;
                Severity: Minor
                Found in lib/grant/code.js - About 1 hr to fix

                  Function exports has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  module.exports = function(options) {
                    options = options || {};
                    
                    var mode = options.mode || 'direct'
                      , fragment = options.fragment || ['token']
                  Severity: Minor
                  Found in lib/middleware/errorHandler.js - About 1 hr to fix

                    Function exports has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    module.exports = function(options, issue) {
                      if (typeof options == 'function') {
                        issue = options;
                        options = undefined;
                      }
                    Severity: Minor
                    Found in lib/exchange/authorizationCode.js - About 1 hr to fix

                      Function _respond has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                      Open

                      Server.prototype._respond = function(txn, res, complete, cb) {
                        if (cb === undefined) {
                          cb = complete;
                          complete = undefined;
                        }
                      Severity: Minor
                      Found in lib/server.js - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function immediated has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              function immediated(err, allow, info, locals) {
                                if (err) { return next(err); }
                                if (allow) {
                                  req.oauth2.res = info || {};
                                  req.oauth2.res.allow = true;
                      Severity: Minor
                      Found in lib/middleware/authorization.js - About 1 hr to fix

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                                server._respond(req.oauth2, res, completing, function(err) {
                                  if (err) { return next(err); }
                                  return next(new AuthorizationError('Unsupported response type: ' + req.oauth2.req.type, 'unsupported_response_type'));
                                });
                        Severity: Major
                        Found in lib/middleware/resume.js and 2 other locations - About 1 hr to fix
                        lib/middleware/authorization.js on lines 153..156
                        lib/middleware/decision.js on lines 122..125

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 66.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                              server._respond(req.oauth2, res, completing, function(err) {
                                if (err) { return next(err); }
                                return next(new AuthorizationError('Unsupported response type: ' + req.oauth2.req.type, 'unsupported_response_type'));
                              });
                        Severity: Major
                        Found in lib/middleware/decision.js and 2 other locations - About 1 hr to fix
                        lib/middleware/authorization.js on lines 153..156
                        lib/middleware/resume.js on lines 59..62

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 66.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                                    server._respond(req.oauth2, res, completing, function(err) {
                                      if (err) { return next(err); }
                                      return next(new AuthorizationError('Unsupported response type: ' + req.oauth2.req.type, 'unsupported_response_type'));
                                    });
                        Severity: Major
                        Found in lib/middleware/authorization.js and 2 other locations - About 1 hr to fix
                        lib/middleware/decision.js on lines 122..125
                        lib/middleware/resume.js on lines 59..62

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 66.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function exports has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                        Open

                        module.exports = function(server, options) {
                          options = options || {};
                          
                          if (!server) { throw new TypeError('oauth2orize.authorizationErrorHandler middleware requires a server argument'); }
                          
                        Severity: Minor
                        Found in lib/middleware/authorizationErrorHandler.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language