jaredhanson/oauth2orize

View on GitHub

Showing 87 of 87 total issues

Function _parse has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

Server.prototype._parse = function(type, req, cb) {
  var ultype = new UnorderedList(type)
    , stack = this._reqParsers
    , areq = {};
  
Severity: Minor
Found in lib/server.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function decision has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  return function decision(req, res, next) {
    if (!req.body) { return next(new Error('OAuth2orize requires body parsing. Did you forget app.use(express.bodyParser())?')); }
    if (!req.oauth2) { return next(new Error('OAuth2orize requires transaction support. Did you forget oauth2orize.transactionLoader(...)?')); }
    
    parse(req, function(err, ares, locals) {
Severity: Minor
Found in lib/middleware/decision.js - About 1 hr to fix

    Function authorization_code has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      return function authorization_code(req, res, next) {
        if (!req.body) { return next(new Error('OAuth2orize requires body parsing. Did you forget app.use(express.bodyParser())?')); }
        
        // The 'user' property of `req` holds the authenticated user.  In the case
        // of the token endpoint, the property will contain the OAuth 2.0 client.
    Severity: Minor
    Found in lib/exchange/authorizationCode.js - About 1 hr to fix

      Function errorHandler has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        return function errorHandler(err, req, res, next) {
          if (mode == 'direct') {
            if (err.status) { res.statusCode = err.status; }
            if (!res.statusCode || res.statusCode < 400) { res.statusCode = 500; }
            
      Severity: Minor
      Found in lib/middleware/errorHandler.js - About 1 hr to fix

        Function deserializeClient has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        Server.prototype.deserializeClient = function(fn, done) {
          if (typeof fn === 'function') {
            return this._deserializers.push(fn);
          }
          
        Severity: Minor
        Found in lib/server.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function grant has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Server.prototype.grant = function(type, phase, fn) {
          if (typeof type == 'object') {
            // sig: grant(mod)
            var mod = type;
            if (mod.request) { this.grant(mod.name, 'request', mod.request); }
        Severity: Minor
        Found in lib/server.js - About 1 hr to fix

          Function _parse has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          Server.prototype._parse = function(type, req, cb) {
            var ultype = new UnorderedList(type)
              , stack = this._reqParsers
              , areq = {};
            
          Severity: Minor
          Found in lib/server.js - About 1 hr to fix

            Function _respond has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            Server.prototype._respond = function(txn, res, complete, cb) {
              if (cb === undefined) {
                cb = complete;
                complete = undefined;
              }
            Severity: Minor
            Found in lib/server.js - About 1 hr to fix

              Function serializeClient has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

              Server.prototype.serializeClient = function(fn, done) {
                if (typeof fn === 'function') {
                  return this._serializers.push(fn);
                }
                
              Severity: Minor
              Found in lib/server.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function exports has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

              module.exports = function(server, options) {
                options = options || {};
                
                if (!server) { throw new TypeError('oauth2orize.transactionLoader middleware requires a server argument'); }
                
              Severity: Minor
              Found in lib/middleware/transactionLoader.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                    if (locals) {
                      req.oauth2.locals = req.oauth2.locals || {};
                      utils.merge(req.oauth2.locals, locals);
                    }
              Severity: Major
              Found in lib/middleware/decision.js and 2 other locations - About 1 hr to fix
              lib/middleware/authorization.js on lines 143..146
              lib/middleware/resume.js on lines 65..68

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                      if (locals) {
                        req.oauth2.locals = req.oauth2.locals || {};
                        utils.merge(req.oauth2.locals, locals);
                      }
              Severity: Major
              Found in lib/middleware/resume.js and 2 other locations - About 1 hr to fix
              lib/middleware/authorization.js on lines 143..146
              lib/middleware/decision.js on lines 93..96

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                          if (locals) {
                            req.oauth2.locals = req.oauth2.locals || {};
                            utils.merge(req.oauth2.locals, locals);
                          }
              Severity: Major
              Found in lib/middleware/authorization.js and 2 other locations - About 1 hr to fix
              lib/middleware/decision.js on lines 93..96
              lib/middleware/resume.js on lines 65..68

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function _exchange has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              Server.prototype._exchange = function(type, req, res, cb) {
                var stack = this._exchanges
                  , idx = 0;
                
                function next(err) {
              Severity: Minor
              Found in lib/server.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                } else if (phase == 'error') {
                  debug('register error handler %s %s', type || '*', fn.name || 'anonymous');
                  this._errHandlers.push({ type: type, handle: fn });
                }
              Severity: Major
              Found in lib/server.js and 2 other locations - About 50 mins to fix
              lib/server.js on lines 86..95
              lib/server.js on lines 89..95

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                if (phase == 'request') {
                  debug('register request parser %s %s', type || '*', fn.name || 'anonymous');
                  this._reqParsers.push({ type: type, handle: fn });
                } else if (phase == 'response') {
                  debug('register response handler %s %s', type || '*', fn.name || 'anonymous');
              Severity: Major
              Found in lib/server.js and 2 other locations - About 50 mins to fix
              lib/server.js on lines 89..95
              lib/server.js on lines 92..95

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                } else if (phase == 'response') {
                  debug('register response handler %s %s', type || '*', fn.name || 'anonymous');
                  this._resHandlers.push({ type: type, handle: fn });
                } else if (phase == 'error') {
                  debug('register error handler %s %s', type || '*', fn.name || 'anonymous');
              Severity: Major
              Found in lib/server.js and 2 other locations - About 50 mins to fix
              lib/server.js on lines 86..95
              lib/server.js on lines 92..95

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function update has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              SessionStore.prototype.update = function(server, options, req, tid, txn, cb) {
              Severity: Minor
              Found in lib/txn/session.js - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    try {
                      layer(client, function(e, o) { pass(i + 1, e, o); } );
                    } catch (ex) {
                      return done(ex);
                    }
                Severity: Minor
                Found in lib/server.js and 1 other location - About 40 mins to fix
                lib/server.js on lines 279..283

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    try {
                      layer(obj, function(e, c) { pass(i + 1, e, c); } );
                    } catch (ex) {
                      return done(ex);
                    }
                Severity: Minor
                Found in lib/server.js and 1 other location - About 40 mins to fix
                lib/server.js on lines 234..238

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language