Sign upLogin

jaredhanson/oauth2orize

View on GitHub
Star

Showing 87 of 87 total issues

Function store has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

SessionStore.prototype.store = function(server, options, req, txn, cb) {
Severity: Minor
Found in lib/txn/session.js - About 35 mins to fix

    Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    module.exports = function(server, options, validate, immediate, complete) {
    Severity: Minor
    Found in lib/middleware/authorization.js - About 35 mins to fix

      Function resume has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      Server.prototype.resume = function(options, immediate, complete) {
  var loader;
  if (typeof options == 'function' && typeof immediate == 'function' && typeof complete == 'function') {
    options = { loadTransaction: options };
  }
      Severity: Minor
      Found in lib/server.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _respondError has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      Server.prototype._respondError = function(err, txn, res, cb) {
  var ultype = new UnorderedList(txn.req.type)
    , stack = this._errHandlers
    , idx = 0;
      Severity: Minor
      Found in lib/server.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

            return next(ex);
      Severity: Major
      Found in lib/exchange/password.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return next(err);
        Severity: Major
        Found in lib/middleware/errorHandler.js - About 30 mins to fix

          Function load has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          SessionStore.prototype.load = function(server, options, req, cb) {
  var field = options.transactionField || 'transaction_id'
    , key = options.sessionKey || 'authorize';
  
  if (!req.session) { return cb(new Error('OAuth2orize requires session support. Did you forget app.use(express.session(...))?')); }
          Severity: Minor
          Found in lib/txn/session.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language