jaredhanson/oauth2orize

View on GitHub
lib/middleware/authorization.js

Summary

Maintainability
F
3 days
Test Coverage

Function exports has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(server, options, validate, immediate, complete) {
  if (typeof options == 'function') {
    complete = immediate;
    immediate = validate;
    validate = options;
Severity: Major
Found in lib/middleware/authorization.js - About 4 hrs to fix

    Function authorization has 88 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      return function authorization(req, res, next) {
        
        var body = req.body || {}
          , type = req.query.response_type || body.response_type;
    
    
    Severity: Major
    Found in lib/middleware/authorization.js - About 3 hrs to fix

      Function validated has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            function validated(err, client, redirectURI, webOrigin) {
              // Set properties *before* next()'ing due to error.  The presence of a
              // redirectURI being provided, even under error conditions, indicates
              // that the client should be informed of the error via a redirect.
              req.oauth2 = {};
      Severity: Major
      Found in lib/middleware/authorization.js - About 2 hrs to fix

        Function immediated has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                function immediated(err, allow, info, locals) {
                  if (err) { return next(err); }
                  if (allow) {
                    req.oauth2.res = info || {};
                    req.oauth2.res.allow = true;
        Severity: Minor
        Found in lib/middleware/authorization.js - About 1 hr to fix

          Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          module.exports = function(server, options, validate, immediate, complete) {
          Severity: Minor
          Found in lib/middleware/authorization.js - About 35 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (arity == 7) {
                      immediate(req.oauth2.client, req.oauth2.user, req.oauth2.req.scope, req.oauth2.req.type, req.oauth2.req, req.oauth2.locals, immediated);
                    } else if (arity == 6) {
                      immediate(req.oauth2.client, req.oauth2.user, req.oauth2.req.scope, req.oauth2.req.type, req.oauth2.req, immediated);
                    } else if (arity == 5) {
            Severity: Major
            Found in lib/middleware/authorization.js and 1 other location - About 1 day to fix
            lib/middleware/resume.js on lines 93..105

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 320.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                        server._respond(req.oauth2, res, completing, function(err) {
                          if (err) { return next(err); }
                          return next(new AuthorizationError('Unsupported response type: ' + req.oauth2.req.type, 'unsupported_response_type'));
                        });
            Severity: Major
            Found in lib/middleware/authorization.js and 2 other locations - About 1 hr to fix
            lib/middleware/decision.js on lines 122..125
            lib/middleware/resume.js on lines 59..62

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                        if (locals) {
                          req.oauth2.locals = req.oauth2.locals || {};
                          utils.merge(req.oauth2.locals, locals);
                        }
            Severity: Major
            Found in lib/middleware/authorization.js and 2 other locations - About 1 hr to fix
            lib/middleware/decision.js on lines 93..96
            lib/middleware/resume.js on lines 65..68

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status