jaredhanson/passport

View on GitHub

Showing 19 of 27 total issues

Function authenticate has a Cognitive Complexity of 113 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function authenticate(passport, name, options, callback) {
  if (typeof options == 'function') {
    callback = options;
    options = {};
  }
Severity: Minor
Found in lib/middleware/authenticate.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function authenticate has 182 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function authenticate(passport, name, options, callback) {
  if (typeof options == 'function') {
    callback = options;
    options = {};
  }
Severity: Major
Found in lib/middleware/authenticate.js - About 7 hrs to fix

    Function authenticate has 170 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      return function authenticate(req, res, next) {
        req.login =
        req.logIn = req.logIn || IncomingMessageExt.logIn;
        req.logout =
        req.logOut = req.logOut || IncomingMessageExt.logOut;
    Severity: Major
    Found in lib/middleware/authenticate.js - About 6 hrs to fix

      Function attempt has 102 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          (function attempt(i) {
            var layer = name[i];
            // If no more strategies exist in the chain, authentication has failed.
            if (!layer) { return allFailed(); }
          
      Severity: Major
      Found in lib/middleware/authenticate.js - About 4 hrs to fix

        Function success has 66 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              strategy.success = function(user, info) {
                if (callback) {
                  return callback(null, user, info);
                }
              
        Severity: Major
        Found in lib/middleware/authenticate.js - About 2 hrs to fix

          Function allFailed has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function allFailed() {
                if (callback) {
                  if (!multi) {
                    return callback(null, false, failures[0].challenge, failures[0].status);
                  } else {
          Severity: Major
          Found in lib/middleware/authenticate.js - About 2 hrs to fix

            Function deserializeUser has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

            Authenticator.prototype.deserializeUser = function(fn, req, done) {
              if (typeof fn === 'function') {
                return this._deserializers.push(fn);
              }
              
            Severity: Minor
            Found in lib/authenticator.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function transformAuthInfo has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

            Authenticator.prototype.transformAuthInfo = function(fn, req, done) {
              if (typeof fn === 'function') {
                return this._infoTransformers.push(fn);
              }
              
            Severity: Minor
            Found in lib/authenticator.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function serializeUser has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

            Authenticator.prototype.serializeUser = function(fn, req, done) {
              if (typeof fn === 'function') {
                return this._serializers.push(fn);
              }
              
            Severity: Minor
            Found in lib/authenticator.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function transformAuthInfo has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            Authenticator.prototype.transformAuthInfo = function(fn, req, done) {
              if (typeof fn === 'function') {
                return this._infoTransformers.push(fn);
              }
              
            Severity: Minor
            Found in lib/authenticator.js - About 1 hr to fix

              Function deserializeUser has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              Authenticator.prototype.deserializeUser = function(fn, req, done) {
                if (typeof fn === 'function') {
                  return this._deserializers.push(fn);
                }
                
              Severity: Minor
              Found in lib/authenticator.js - About 1 hr to fix

                Function serializeUser has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                Authenticator.prototype.serializeUser = function(fn, req, done) {
                  if (typeof fn === 'function') {
                    return this._serializers.push(fn);
                  }
                  
                Severity: Minor
                Found in lib/authenticator.js - About 1 hr to fix

                  Function logIn has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  SessionManager.prototype.logIn = function(req, user, options, cb) {
                    if (typeof options == 'function') {
                      cb = options;
                      options = {};
                    }
                  Severity: Minor
                  Found in lib/sessionmanager.js - About 1 hr to fix

                    Function logIn has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                    req.logIn = function(user, options, done) {
                      if (typeof options == 'function') {
                        done = options;
                        options = {};
                      }
                    Severity: Minor
                    Found in lib/http/request.js - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    module.exports = function initialize(passport, options) {
                      options = options || {};
                      
                      return function initialize(req, res, next) {
                        req.login =
                    Severity: Minor
                    Found in lib/middleware/initialize.js - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Consider simplifying this complex logical expression.
                    Open

                          if (options.failureFlash) {
                            var flash = options.failureFlash;
                            if (typeof flash == 'string') {
                              flash = { type: 'error', message: flash };
                            }
                    Severity: Major
                    Found in lib/middleware/authenticate.js - About 40 mins to fix

                      Consider simplifying this complex logical expression.
                      Open

                              if (options.successFlash) {
                                var flash = options.successFlash;
                                if (typeof flash == 'string') {
                                  flash = { type: 'success', message: flash };
                                }
                      Severity: Major
                      Found in lib/middleware/authenticate.js - About 40 mins to fix

                        Function logOut has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                        req.logOut = function(options, done) {
                          if (typeof options == 'function') {
                            done = options;
                            options = {};
                          }
                        Severity: Minor
                        Found in lib/http/request.js - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function authenticate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        SessionStrategy.prototype.authenticate = function(req, options) {
                          if (!req.session) { return this.error(new Error('Login sessions require session support. Did you forget to use `express-session` middleware?')); }
                          options = options || {};
                        
                          var self = this, 
                        Severity: Minor
                        Found in lib/strategies/session.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language