jaredhanson/passport

View on GitHub
lib/middleware/authenticate.js

Summary

Maintainability
F
1 wk
Test Coverage

Function authenticate has a Cognitive Complexity of 113 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function authenticate(passport, name, options, callback) {
  if (typeof options == 'function') {
    callback = options;
    options = {};
  }
Severity: Minor
Found in lib/middleware/authenticate.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function authenticate has 182 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function authenticate(passport, name, options, callback) {
  if (typeof options == 'function') {
    callback = options;
    options = {};
  }
Severity: Major
Found in lib/middleware/authenticate.js - About 7 hrs to fix

    Function authenticate has 170 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      return function authenticate(req, res, next) {
        req.login =
        req.logIn = req.logIn || IncomingMessageExt.logIn;
        req.logout =
        req.logOut = req.logOut || IncomingMessageExt.logOut;
    Severity: Major
    Found in lib/middleware/authenticate.js - About 6 hrs to fix

      Function attempt has 102 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          (function attempt(i) {
            var layer = name[i];
            // If no more strategies exist in the chain, authentication has failed.
            if (!layer) { return allFailed(); }
          
      Severity: Major
      Found in lib/middleware/authenticate.js - About 4 hrs to fix

        Function success has 66 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              strategy.success = function(user, info) {
                if (callback) {
                  return callback(null, user, info);
                }
              
        Severity: Major
        Found in lib/middleware/authenticate.js - About 2 hrs to fix

          Function allFailed has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function allFailed() {
                if (callback) {
                  if (!multi) {
                    return callback(null, false, failures[0].challenge, failures[0].status);
                  } else {
          Severity: Major
          Found in lib/middleware/authenticate.js - About 2 hrs to fix

            Consider simplifying this complex logical expression.
            Open

                    if (options.successFlash) {
                      var flash = options.successFlash;
                      if (typeof flash == 'string') {
                        flash = { type: 'success', message: flash };
                      }
            Severity: Major
            Found in lib/middleware/authenticate.js - About 40 mins to fix

              Consider simplifying this complex logical expression.
              Open

                    if (options.failureFlash) {
                      var flash = options.failureFlash;
                      if (typeof flash == 'string') {
                        flash = { type: 'error', message: flash };
                      }
              Severity: Major
              Found in lib/middleware/authenticate.js - About 40 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (options.successFlash) {
                          var flash = options.successFlash;
                          if (typeof flash == 'string') {
                            flash = { type: 'success', message: flash };
                          }
                Severity: Major
                Found in lib/middleware/authenticate.js and 1 other location - About 5 hrs to fix
                lib/middleware/authenticate.js on lines 124..136

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 143.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      if (options.failureFlash) {
                        var flash = options.failureFlash;
                        if (typeof flash == 'string') {
                          flash = { type: 'error', message: flash };
                        }
                Severity: Major
                Found in lib/middleware/authenticate.js and 1 other location - About 5 hrs to fix
                lib/middleware/authenticate.js on lines 228..240

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 143.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      if (options.failureMessage) {
                        msg = options.failureMessage;
                        if (typeof msg == 'boolean') {
                          msg = challenge.message || challenge;
                        }
                Severity: Major
                Found in lib/middleware/authenticate.js and 1 other location - About 3 hrs to fix
                lib/middleware/authenticate.js on lines 241..250

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 110.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (options.successMessage) {
                          msg = options.successMessage;
                          if (typeof msg == 'boolean') {
                            msg = info.message || info;
                          }
                Severity: Major
                Found in lib/middleware/authenticate.js and 1 other location - About 3 hrs to fix
                lib/middleware/authenticate.js on lines 137..146

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 110.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          if (options.authInfo !== false) {
                            passport.transformAuthInfo(info, req, function(err, tinfo) {
                              if (err) { return next(err); }
                              req.authInfo = tinfo;
                              next();
                Severity: Major
                Found in lib/middleware/authenticate.js and 1 other location - About 2 hrs to fix
                lib/middleware/authenticate.js on lines 283..291

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 76.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          if (options.authInfo !== false) {
                            passport.transformAuthInfo(info, req, function(err, tinfo) {
                              if (err) { return next(err); }
                              req.authInfo = tinfo;
                              complete();
                Severity: Major
                Found in lib/middleware/authenticate.js and 1 other location - About 2 hrs to fix
                lib/middleware/authenticate.js on lines 253..261

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 76.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status