jbox-web/redmine_git_hosting

View on GitHub
app/controllers/redmine_git_hosting_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method check_xitolite_permissions has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def check_xitolite_permissions
      case self.action_name
      when 'index', 'show'
        perm = "view_#{self.controller_name}".to_sym
        render_403 unless User.current.git_allowed_to?(perm, @repository)
Severity: Minor
Found in app/controllers/redmine_git_hosting_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status