jbox-web/redmine_git_hosting

View on GitHub
app/controllers/repository_deployment_credentials_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method build_new_credential has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def build_new_credential
    credential = @repository.deployment_credentials.new
    credential.safe_attributes = params[:repository_deployment_credential]
    key = GitolitePublicKey.find_by(id: params[:repository_deployment_credential][:gitolite_public_key_id])

Severity: Minor
Found in app/controllers/repository_deployment_credentials_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_deployment_credential has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def find_deployment_credential
    credential = @repository.deployment_credentials.find(params[:id])
  rescue ActiveRecord::RecordNotFound
    render_404
  else
Severity: Minor
Found in app/controllers/repository_deployment_credentials_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status