Showing 7 of 7 total issues
Class JenkinsJobPresenter
has 24 methods (exceeds 20 allowed). Consider refactoring. Open
class JenkinsJobPresenter < SimpleDelegator
attr_reader :jenkins_job
def initialize(jenkins_job, template)
Method conditions_for
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
def conditions_for(field, operator, value)
retval = ""
available_filters
return retval unless @jenkins_filters
Method sql_for_field_with_redmine_jenkins
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def sql_for_field_with_redmine_jenkins(field, operator, value, db_table, db_field, is_custom_filter=false)
Method view_layouts_base_html_head
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def view_layouts_base_html_head(context={})
project = context[:project]
return '' unless project
controller = context[:controller]
return '' unless controller
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_job_status
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def update_job_status
jenkins_job.state = color_to_state(job_data['color']) || jenkins_job.state
jenkins_job.description = job_data['description'] || ''
jenkins_job.health_report = job_data['healthReport']
jenkins_job.latest_build_number = !job_data['lastBuild'].nil? ? job_data['lastBuild']['number'] : 0
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create_changeset
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def create_changeset(build, changesets)
changesets.each do |changeset|
build_changeset = jenkins_job.repository.changesets.find_by_revision(changeset['commitId'])
next if build_changeset.nil?
build.changesets << build_changeset unless build.changesets.include?(build_changeset)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method available_filters_with_redmine_jenkins
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def available_filters_with_redmine_jenkins
return @available_filters if @available_filters
available_filters_without_redmine_jenkins
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"