Sign upLogin

jcgertig/react-pundit

View on GitHub
Star

Showing 5 of 5 total issues

Function getChildContext has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Confirmed

  getChildContext() {
    const punditCheck = (type, action, model = null, user = null) => {
      const { policies } = this.props;
      let policy;
      if (Array.isArray(policies)) {
Severity: Minor
Found in src/PunditContainer.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Confirmed

        if (typeof policy[action] !== 'function') { return false; }
Severity: Major
Found in src/PunditContainer.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Confirmed

            return policy[action].apply(null, [model, user || this.props.user]);
    Severity: Major
    Found in src/PunditContainer.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Confirmed

            return false;
      Severity: Major
      Found in src/PunditContainer.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Confirmed

                return policy[action].apply(null, [model, user || this.props.user]);
        Severity: Major
        Found in src/PunditContainer.js - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language