jdutil/spree_marketplace

View on GitHub

Showing 8 of 8 total issues

Method initialize has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize(user)
      user ||= Spree.user_class.new

      if user.supplier
        if SpreeMarketplace::Engine.spree_digital_available?
Severity: Major
Found in app/models/spree/supplier_ability.rb - About 2 hrs to fix

    Method create has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
        authorize! :create, Spree::Supplier
    
        @supplier = Spree::Supplier.new(supplier_params)
    
    
    Severity: Minor
    Found in app/controllers/spree/suppliers_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method stripe_recipient_setup has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def stripe_recipient_setup
        return if self.tax_id.blank? and self.address.blank?
    
        recipient = Stripe::Recipient.create(
          :name => (self.merchant_type == 'business' ? self.name : "#{self.address.first_name} #{self.address.last_name}"),
    Severity: Minor
    Found in app/models/spree/supplier_decorator.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method stripe_recipient_update has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def stripe_recipient_update
        unless new_record? or !changed?
          if token.present?
            rp = Stripe::Recipient.retrieve(token)
            rp.name  = name
    Severity: Minor
    Found in app/models/spree/supplier_decorator.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(user)
          user ||= Spree.user_class.new
    
          if user.supplier
            if SpreeMarketplace::Engine.spree_digital_available?
    Severity: Minor
    Found in app/models/spree/supplier_ability.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method assign_name has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def assign_name
        self.address = Spree::Address.default     unless self.address.present?
        self.address.first_name = self.first_name unless self.address.first_name.present?
        self.address.last_name = self.last_name   unless self.address.last_name.present?
      end
    Severity: Minor
    Found in app/models/spree/supplier_decorator.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        preference :stripe_publishable_key, :string, default: -> {
          if ActiveRecord::Base.connection.table_exists?(:spree_payment_methods)
            # If you are using Stripe as a credit card processor we automatically lookup your api key to use for payments.
            Spree::PaymentMethod.where(type: 'Spree::Gateway::StripeGateway', environment: Rails.env).first.try(:preferred_publishable_key)
          else
    Severity: Minor
    Found in app/models/spree/marketplace_configuration.rb and 1 other location - About 20 mins to fix
    app/models/spree/marketplace_configuration.rb on lines 17..26

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        preference :stripe_secret_key, :string, default: -> {
          if ActiveRecord::Base.connection.table_exists?(:spree_payment_methods)
            # If you are using Stripe as a credit card processor we automatically lookup your api key to use for payments.
            Spree::PaymentMethod.where(type: 'Spree::Gateway::StripeGateway', environment: Rails.env).first.try(:preferred_secret_key)
          else
    Severity: Minor
    Found in app/models/spree/marketplace_configuration.rb and 1 other location - About 20 mins to fix
    app/models/spree/marketplace_configuration.rb on lines 8..17

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language