Sign upLogin

jdxcode/npm-register

View on GitHub
Star

Showing 3 of 7 total issues

Function get has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

async function get (name, etag) {
  try {
    if (etag && redis && (await isEtagFresh(name, etag))) return 304
    let pkg = redis ? await fetchFromCache(name) : null
    if (pkg) return pkg
Severity: Minor
Found in lib/npm.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return 304
Severity: Major
Found in lib/npm.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return 404
    Severity: Major
    Found in lib/npm.js - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language