Sign upLogin

jejacks0n/navigasmic

View on GitHub
Star

Showing 11 of 11 total issues

Method item has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def item(label, *args, &block)
        options = args.extract_options!
        options = flatten_and_eval_options(options)
        return "" unless visible?(options)
Severity: Minor
Found in lib/navigasmic/builder/crumb_builder.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method highlights_on? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def highlights_on?(path, params)
      return false unless @rules.any?
      params = params.except(*unwanted_keys)
      !!@rules.detect do |rule|
        case rule
Severity: Minor
Found in lib/navigasmic/item.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        def label_for(label, link, is_nested = false, options = {})
          if label.present?
            label = @context.instance_exec(label, options, !!link, is_nested, &@config.label_generator).html_safe
          end
          label = @context.instance_exec(label, link, options.delete(:link_html) || {}, is_nested, &@config.link_generator).html_safe if link
Severity: Minor
Found in lib/navigasmic/builder/list_builder.rb and 1 other location - About 45 mins to fix
lib/navigasmic/builder/crumb_builder.rb on lines 62..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method flatten_and_eval_options has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def flatten_and_eval_options(options)
          remove_excluded_options(options)
          options.inject({}) do |hash, (key, value)|
            if value.is_a?(Array)
              value = value.map { |v| v.is_a?(Proc) ? eval_in_context(&v) : v }
Severity: Minor
Found in lib/navigasmic/builder/base.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        def label_for(label, link, is_nested = false, options = {})
          if label.present?
            label = @context.instance_exec(label, options, !!link, is_nested, &@config.label_generator).html_safe
          end
          label = @context.instance_exec(label, link, options.delete(:link_html) || {}, is_nested, &@config.link_generator).html_safe if link
Severity: Minor
Found in lib/navigasmic/builder/crumb_builder.rb and 1 other location - About 45 mins to fix
lib/navigasmic/builder/list_builder.rb on lines 88..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method item has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def item(label, *args, &block)
        options = args.extract_options!
        options = flatten_and_eval_options(options)
        return "" unless visible?(options)
Severity: Minor
Found in lib/navigasmic/builder/list_builder.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method determine_link has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        def determine_link(label, link)
          if link.blank?
            path_helper = "#{label.to_s.underscore.gsub(/\s/, '_')}_path"
            @context.send(path_helper) if @context.respond_to?(path_helper)
          elsif link.is_a?(Proc)
Severity: Minor
Found in lib/navigasmic/builder/base.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method link_for has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        def link_for(link, options)
          host = options.delete(:host) || @context.request.host
          if link.is_a?(Hash)
            link[:host] ||= host
          elsif link[0] == "/"
Severity: Minor
Found in lib/navigasmic/builder/map_builder.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method group has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def group(label_or_options = nil, options = {}, &block)
        raise ArgumentError, "Missing block for group" unless block_given?
        if label_or_options.is_a?(Hash)
          options = label_or_options
          label_or_options = nil
Severity: Minor
Found in lib/navigasmic/builder/list_builder.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method structure_for has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def structure_for(label, link, options, &block)
          content = content_tag(:loc, link_for(link, options))
          content << content_tag(:name, label)
          if opts = options.delete(@config.option_namespace)
            content << content_tag(:changefreq, opts[:changefreq] || @config.item_changefreq)
Severity: Minor
Found in lib/navigasmic/builder/map_builder.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method calculate_highlighting_rules has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def calculate_highlighting_rules(rules)
        [].tap do |highlighting_rules|
          if rules.nil?
            highlighting_rules << @link if link?
          else
Severity: Minor
Found in lib/navigasmic/item.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language