Sign upLogin

jelhan/croodle

View on GitHub
Star

Showing 27 of 31 total issues

Avoid too many return statements within this method.
Open

    if (strlen($decoded['iv'])>24) return false;
Severity: Major
Found in api/classes/model.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

        if (base64_decode($decoded['cipher'],$strict=true)==null) { return false; }
    Severity: Major
    Found in api/classes/model.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          if (count(array_intersect(array_keys($decoded),$accepted_keys))!=10) { return false; }
      Severity: Major
      Found in api/classes/model.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            if (strlen($decoded['salt'])>14) return false;
        Severity: Major
        Found in api/classes/model.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return $model;
          Severity: Major
          Found in api/classes/model.php - About 30 mins to fix

            Function submit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              @action
  async submit() {
    const { formData, poll } = this.model;
    const { name } = formData;
    const { answers, isFreeText } = poll;
            Severity: Minor
            Found in app/controllers/poll/participation.ts - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function bestOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              get bestOptions(): BestOption[] | null {
    const { poll } = this.args;
    const { isFreeText, options, users } = poll;

    // can not evaluate answer type free text
            Severity: Minor
            Found in app/components/poll-evaluation-summary.ts - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language