Sign upLogin

jens-maus/yam

View on GitHub
Star

Showing 10 of 10 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

              elseif($tag == "URL:" && ($value1 == $userTARGET || $value1 == "*"))
              {
                 // output the initial [UPDATE] header only once
                 if($updateFound == false)
                 {
Severity: Major
Found in www/update.yam.ch/index.php and 1 other location - About 6 hrs to fix
www/update.yam.ch/index.php on lines 213..237

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 214.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

              elseif($tag == "URL:" && ($value1 == $userTARGET || $value1 == "*"))
              {
                 // output the initial [UPDATE] header only once
                 if($updateFound == false)
                 {
Severity: Major
Found in www/update.yam.ch/index.php and 1 other location - About 6 hrs to fix
www/update.yam.ch/index.php on lines 299..323

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 214.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File index.php has 283 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/***************************************************************************

 YAM - Yet Another Mailer
 Copyright (C) 1995-2000 by Marcel Beck <mbeck@yam.ch>
Severity: Minor
Found in www/update.yam.ch/index.php - About 2 hrs to fix

Avoid deeply nested control flow statements.
Open

         while(!feof($fh))
         {
            $line = fgets($fh);
            list($tag, $value1, $value2, $value3) = explode(" ", trim($line), 4);
Severity: Major
Found in www/update.yam.ch/index.php - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

              if($changelog == true)
                 fputs($out, $line);
              elseif($tag == "VERSION:")
              {
                 $updateVER = $value1;
Severity: Major
Found in www/update.yam.ch/index.php - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

              if($changelog == true)
                 fputs($out, $line);
              elseif($tag == "VERSION:")
                 $updateVER = $value1;
              elseif($tag == "BUILDID:")
Severity: Major
Found in www/update.yam.ch/index.php - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

         if($changelog == true)
            fprintf($out, "</changelog>\n");
Severity: Major
Found in www/update.yam.ch/index.php - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

         if($updateFound == true)
            fprintf($out, "</component>\n");
Severity: Major
Found in www/update.yam.ch/index.php - About 45 mins to fix

Consider simplifying this complex logical expression.
Open

                 if($userVER > $updateVERSION || 
                    ($userVER == $updateVERSION && $userREV > $updateREVISION) ||
                    ($userVER == $updateVERSION && $userREV == $updateREVISION && $userPL > $updatePL))
                 {
                    break;
Severity: Major
Found in www/update.yam.ch/index.php - About 40 mins to fix

Consider simplifying this complex logical expression.
Open

  if($userVER >= 2 && $userREV >= 4 && $userPL >= 0 &&
     $stableVER >= 2 && $stableREV >= 4 && $stablePL >= 0)
  {
     // check if the user version is a nightly build and if so we check
     // the stable version against the user version and in case the stable version is
Severity: Major
Found in www/update.yam.ch/index.php - About 40 mins to fix
Severity
Category
Status
Source
Language