Sign upLogin

jens-maus/yam

View on GitHub
Star

Showing 8 of 10 total issues

File index.php has 283 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/***************************************************************************

 YAM - Yet Another Mailer
 Copyright (C) 1995-2000 by Marcel Beck <mbeck@yam.ch>
Severity: Minor
Found in www/update.yam.ch/index.php - About 2 hrs to fix

Avoid deeply nested control flow statements.
Open

         while(!feof($fh))
         {
            $line = fgets($fh);
            list($tag, $value1, $value2, $value3) = explode(" ", trim($line), 4);
Severity: Major
Found in www/update.yam.ch/index.php - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

              if($changelog == true)
                 fputs($out, $line);
              elseif($tag == "VERSION:")
              {
                 $updateVER = $value1;
Severity: Major
Found in www/update.yam.ch/index.php - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

              if($changelog == true)
                 fputs($out, $line);
              elseif($tag == "VERSION:")
                 $updateVER = $value1;
              elseif($tag == "BUILDID:")
Severity: Major
Found in www/update.yam.ch/index.php - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

         if($changelog == true)
            fprintf($out, "</changelog>\n");
Severity: Major
Found in www/update.yam.ch/index.php - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

         if($updateFound == true)
            fprintf($out, "</component>\n");
Severity: Major
Found in www/update.yam.ch/index.php - About 45 mins to fix

Consider simplifying this complex logical expression.
Open

                 if($userVER > $updateVERSION || 
                    ($userVER == $updateVERSION && $userREV > $updateREVISION) ||
                    ($userVER == $updateVERSION && $userREV == $updateREVISION && $userPL > $updatePL))
                 {
                    break;
Severity: Major
Found in www/update.yam.ch/index.php - About 40 mins to fix

Consider simplifying this complex logical expression.
Open

  if($userVER >= 2 && $userREV >= 4 && $userPL >= 0 &&
     $stableVER >= 2 && $stableREV >= 4 && $stablePL >= 0)
  {
     // check if the user version is a nightly build and if so we check
     // the stable version against the user version and in case the stable version is
Severity: Major
Found in www/update.yam.ch/index.php - About 40 mins to fix
Severity
Category
Status
Source
Language