Sign upLogin

jetrockets/corelogic-ruby

View on GitHub
Star

Showing 3 of 3 total issues

Method property_detail has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def property_detail(property)
        response = perform_response("property/#{property.id}/property-detail")

        property.assign_data!(response[:property])
        property.ownership = Property::Ownership.new(response[:ownership]) if response[:ownership]
Severity: Minor
Found in lib/corelogic/api/properties_repository.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method perform_response has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def perform_response(path, options = {})
        try = 0
        begin
          try += 1
          response_parser.perform(perform_get(path, options))
Severity: Minor
Found in lib/corelogic/api/properties_repository.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(klass, raw_hash)
      @klass = klass.is_a?(::String) ? ::Object.const_get(klass) : klass
      @raw_hash = raw_hash

      @total_pages = raw_hash[:totalPages] || 1
Severity: Minor
Found in lib/corelogic/collection.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language