jiahaog/nativefier

View on GitHub

Showing 52 of 52 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test('foreground tabs with internal urls should be opened in the foreground', () => {
  const openExternal = jest.fn();
  const createAboutBlankWindow = jest.fn();
  const createNewTab = jest.fn();
  const preventDefault = jest.fn();
Severity: Major
Found in app/src/components/mainWindowHelpers.test.ts and 1 other location - About 1 day to fix
app/src/components/mainWindowHelpers.test.ts on lines 183..210

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 266.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test('background tabs with internal urls should be opened in background tabs', () => {
  const openExternal = jest.fn();
  const createAboutBlankWindow = jest.fn();
  const createNewTab = jest.fn();
  const preventDefault = jest.fn();
Severity: Major
Found in app/src/components/mainWindowHelpers.test.ts and 1 other location - About 1 day to fix
app/src/components/mainWindowHelpers.test.ts on lines 154..181

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 266.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function createMainWindow has 273 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function createMainWindow(
  nativefierOptions,
  onAppQuit,
  setDockBadge,
): BrowserWindow {
Severity: Major
Found in app/src/components/mainWindow.ts - About 1 day to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    test('tab disposition should be ignored if url is external', () => {
      const openExternal = jest.fn();
      const createAboutBlankWindow = jest.fn();
      const createNewTab = jest.fn();
      const preventDefault = jest.fn();
    Severity: Major
    Found in app/src/components/mainWindowHelpers.test.ts and 3 other locations - About 1 day to fix
    app/src/components/mainWindowHelpers.test.ts on lines 13..39
    app/src/components/mainWindowHelpers.test.ts on lines 41..67
    app/src/components/mainWindowHelpers.test.ts on lines 98..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 235.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    test('external urls should be opened externally', () => {
      const openExternal = jest.fn();
      const createAboutBlankWindow = jest.fn();
      const createNewTab = jest.fn();
      const preventDefault = jest.fn();
    Severity: Major
    Found in app/src/components/mainWindowHelpers.test.ts and 3 other locations - About 1 day to fix
    app/src/components/mainWindowHelpers.test.ts on lines 13..39
    app/src/components/mainWindowHelpers.test.ts on lines 98..124
    app/src/components/mainWindowHelpers.test.ts on lines 126..152

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 235.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    test('tab disposition should be ignored if tabs are not enabled', () => {
      const preventDefault = jest.fn();
      const openExternal = jest.fn();
      const createAboutBlankWindow = jest.fn();
      const createNewTab = jest.fn();
    Severity: Major
    Found in app/src/components/mainWindowHelpers.test.ts and 3 other locations - About 1 day to fix
    app/src/components/mainWindowHelpers.test.ts on lines 13..39
    app/src/components/mainWindowHelpers.test.ts on lines 41..67
    app/src/components/mainWindowHelpers.test.ts on lines 126..152

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 235.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    test('internal urls should not be handled', () => {
      const preventDefault = jest.fn();
      const openExternal = jest.fn();
      const createAboutBlankWindow = jest.fn();
      const createNewTab = jest.fn();
    Severity: Major
    Found in app/src/components/mainWindowHelpers.test.ts and 3 other locations - About 1 day to fix
    app/src/components/mainWindowHelpers.test.ts on lines 41..67
    app/src/components/mainWindowHelpers.test.ts on lines 98..124
    app/src/components/mainWindowHelpers.test.ts on lines 126..152

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 235.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function getOptions has 149 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function getOptions(rawOptions: any): Promise<AppOptions> {
      const options: AppOptions = {
        packager: {
          appCopyright: rawOptions.appCopyright,
          appVersion: rawOptions.appVersion,
    Severity: Major
    Found in src/options/optionsMain.ts - About 5 hrs to fix

      Function createMainWindow has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
      Open

      export function createMainWindow(
        nativefierOptions,
        onAppQuit,
        setDockBadge,
      ): BrowserWindow {
      Severity: Minor
      Found in app/src/components/mainWindow.ts - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File mainWindow.ts has 337 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import * as fs from 'fs';
      import * as path from 'path';
      
      import { BrowserWindow, shell, ipcMain, dialog, Event } from 'electron';
      import windowStateKeeper from 'electron-window-state';
      Severity: Minor
      Found in app/src/components/mainWindow.ts - About 4 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if (options.packager.platform === 'win32') {
            if (iconIsIco(options.packager.icon)) {
              log.debug(
                'Building for Windows and icon is already a .ico, no conversion needed',
              );
        Severity: Major
        Found in src/build/buildIcon.ts and 1 other location - About 3 hrs to fix
        src/build/buildIcon.ts on lines 55..71

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if (options.packager.platform === 'linux') {
            if (iconIsPng(options.packager.icon)) {
              log.debug(
                'Building for Linux and icon is already a .png, no conversion needed',
              );
        Severity: Major
        Found in src/build/buildIcon.ts and 1 other location - About 3 hrs to fix
        src/build/buildIcon.ts on lines 37..53

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function getOptions has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
        Open

        export async function getOptions(rawOptions: any): Promise<AppOptions> {
          const options: AppOptions = {
            packager: {
              appCopyright: rawOptions.appCopyright,
              appVersion: rawOptions.appVersion,
        Severity: Minor
        Found in src/options/optionsMain.ts - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File cli.ts has 289 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        #!/usr/bin/env node
        import 'source-map-support/register';
        
        import * as commander from 'commander';
        import * as dns from 'dns';
        Severity: Minor
        Found in src/cli.ts - About 2 hrs to fix

          Function createMenu has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

          export function createMenu({
            nativefierVersion,
            appQuit,
            zoomIn,
            zoomOut,
          Severity: Minor
          Found in app/src/components/menu.ts - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function findSync has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

          function findSync(
            pattern: RegExp,
            basePath: string,
            limitSearchToDirectories = false,
          ): string[] {
          Severity: Minor
          Found in app/src/helpers/inferFlash.ts - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File menu.ts has 280 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          import { Menu, clipboard, shell, MenuItemConstructorOptions } from 'electron';
          
          export function createMenu({
            nativefierVersion,
            appQuit,
          Severity: Minor
          Found in app/src/components/menu.ts - About 2 hrs to fix

            Function getAllowedIconFormats has 63 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function getAllowedIconFormats(platform: string): string[] {
              const hasIdentify = hasbin.sync('identify');
              const hasConvert = hasbin.sync('convert');
              const hasIconUtil = hasbin.sync('iconutil');
            
            
            Severity: Major
            Found in src/helpers/helpers.ts - About 2 hrs to fix

              Function getAllowedIconFormats has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

              export function getAllowedIconFormats(platform: string): string[] {
                const hasIdentify = hasbin.sync('identify');
                const hasConvert = hasbin.sync('convert');
                const hasIconUtil = hasbin.sync('iconutil');
              
              
              Severity: Minor
              Found in src/helpers/helpers.ts - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function convertIconIfNecessary has 57 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export async function convertIconIfNecessary(
                options: AppOptions,
              ): Promise<void> {
                if (!options.packager.icon) {
                  log.debug('Option "icon" not set, skipping icon conversion.');
              Severity: Major
              Found in src/build/buildIcon.ts - About 2 hrs to fix
                Severity
                Category
                Status
                Source
                Language