jiahaog/nativefier

View on GitHub

Showing 56 of 56 total issues

Function createMainWindow has 257 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createMainWindow(inpOptions, onAppQuit, setDockBadge) {
  const options = Object.assign({}, inpOptions);
  const mainWindowState = windowStateKeeper({
    defaultWidth: options.width || 1280,
    defaultHeight: options.height || 800,
Severity: Major
Found in app/src/components/mainWindow/mainWindow.js - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    test('foreground tabs with internal urls should be opened in the foreground', () => {
      const openExternal = jest.fn();
      const createAboutBlankWindow = jest.fn();
      const createNewTab = jest.fn();
      const preventDefault = jest.fn();
    Severity: Major
    Found in app/src/components/mainWindow/mainWindowHelpers.test.js and 1 other location - About 1 day to fix
    app/src/components/mainWindow/mainWindowHelpers.test.js on lines 125..146

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 223.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    test('background tabs with internal urls should be opened in background tabs', () => {
      const openExternal = jest.fn();
      const createAboutBlankWindow = jest.fn();
      const createNewTab = jest.fn();
      const preventDefault = jest.fn();
    Severity: Major
    Found in app/src/components/mainWindow/mainWindowHelpers.test.js and 1 other location - About 1 day to fix
    app/src/components/mainWindow/mainWindowHelpers.test.js on lines 102..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 223.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    test('tab disposition should be ignored if url is external', () => {
      const openExternal = jest.fn();
      const createAboutBlankWindow = jest.fn();
      const createNewTab = jest.fn();
      const preventDefault = jest.fn();
    Severity: Major
    Found in app/src/components/mainWindow/mainWindowHelpers.test.js and 3 other locations - About 7 hrs to fix
    app/src/components/mainWindow/mainWindowHelpers.test.js on lines 14..34
    app/src/components/mainWindow/mainWindowHelpers.test.js on lines 36..56
    app/src/components/mainWindow/mainWindowHelpers.test.js on lines 58..78

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 192.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    test('internal urls should not be handled', () => {
      const preventDefault = jest.fn();
      const openExternal = jest.fn();
      const createAboutBlankWindow = jest.fn();
      const createNewTab = jest.fn();
    Severity: Major
    Found in app/src/components/mainWindow/mainWindowHelpers.test.js and 3 other locations - About 7 hrs to fix
    app/src/components/mainWindow/mainWindowHelpers.test.js on lines 36..56
    app/src/components/mainWindow/mainWindowHelpers.test.js on lines 58..78
    app/src/components/mainWindow/mainWindowHelpers.test.js on lines 80..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 192.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    test('tab disposition should be ignored if tabs are not enabled', () => {
      const preventDefault = jest.fn();
      const openExternal = jest.fn();
      const createAboutBlankWindow = jest.fn();
      const createNewTab = jest.fn();
    Severity: Major
    Found in app/src/components/mainWindow/mainWindowHelpers.test.js and 3 other locations - About 7 hrs to fix
    app/src/components/mainWindow/mainWindowHelpers.test.js on lines 14..34
    app/src/components/mainWindow/mainWindowHelpers.test.js on lines 36..56
    app/src/components/mainWindow/mainWindowHelpers.test.js on lines 80..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 192.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    test('external urls should be opened externally', () => {
      const openExternal = jest.fn();
      const createAboutBlankWindow = jest.fn();
      const createNewTab = jest.fn();
      const preventDefault = jest.fn();
    Severity: Major
    Found in app/src/components/mainWindow/mainWindowHelpers.test.js and 3 other locations - About 7 hrs to fix
    app/src/components/mainWindow/mainWindowHelpers.test.js on lines 14..34
    app/src/components/mainWindow/mainWindowHelpers.test.js on lines 58..78
    app/src/components/mainWindow/mainWindowHelpers.test.js on lines 80..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 192.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function default has 103 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function(inpOptions) {
      const options = {
        dir: PLACEHOLDER_APP_DIR,
        name: inpOptions.name,
        targetUrl: normalizeUrl(inpOptions.targetUrl),
    Severity: Major
    Found in src/options/optionsMain.js - About 4 hrs to fix

      File mainWindow.js has 328 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import fs from 'fs';
      import path from 'path';
      import { BrowserWindow, shell, ipcMain, dialog } from 'electron';
      import windowStateKeeper from 'electron-window-state';
      import mainWindowHelpers from './mainWindowHelpers';
      Severity: Minor
      Found in app/src/components/mainWindow/mainWindow.js - About 3 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if (options.platform === 'linux') {
            if (iconIsPng(options.icon)) {
              returnCallback();
              return;
            }
        Severity: Major
        Found in src/build/iconBuild.js and 1 other location - About 3 hrs to fix
        src/build/iconBuild.js on lines 45..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if (options.platform === 'win32') {
            if (iconIsIco(options.icon)) {
              returnCallback();
              return;
            }
        Severity: Major
        Found in src/build/iconBuild.js and 1 other location - About 3 hrs to fix
        src/build/iconBuild.js on lines 63..79

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function createMainWindow has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
        Open

        function createMainWindow(inpOptions, onAppQuit, setDockBadge) {
          const options = Object.assign({}, inpOptions);
          const mainWindowState = windowStateKeeper({
            defaultWidth: options.width || 1280,
            defaultHeight: options.height || 800,
        Severity: Minor
        Found in app/src/components/mainWindow/mainWindow.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function buildMain has 72 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function buildMain(inpOptions, callback) {
          const options = Object.assign({}, inpOptions);
        
          // pre process app
          const tmpObj = tmp.dirSync({ mode: '0755', unsafeCleanup: true });
        Severity: Major
        Found in src/build/buildMain.js - About 2 hrs to fix

          Function createMenu has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

          function createMenu({
            nativefierVersion,
            appQuit,
            zoomIn,
            zoomOut,
          Severity: Minor
          Found in app/src/components/menu/menu.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function allowedIconFormats has 62 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function allowedIconFormats(platform) {
            const hasIdentify = hasBinary.sync('identify');
            const hasConvert = hasBinary.sync('convert');
            const hasIconUtil = hasBinary.sync('iconutil');
          
          
          Severity: Major
          Found in src/helpers/helpers.js - About 2 hrs to fix

            Function iconBuild has 61 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function iconBuild(inpOptions, callback) {
              const options = Object.assign({}, inpOptions);
              const returnCallback = () => {
                callback(null, options);
              };
            Severity: Major
            Found in src/build/iconBuild.js - About 2 hrs to fix

              Function allowedIconFormats has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

              function allowedIconFormats(platform) {
                const hasIdentify = hasBinary.sync('identify');
                const hasConvert = hasBinary.sync('convert');
                const hasIconUtil = hasBinary.sync('iconutil');
              
              
              Severity: Minor
              Found in src/helpers/helpers.js - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File menu.js has 262 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              import { Menu, shell, clipboard } from 'electron';
              
              /**
               * @param nativefierVersion
               * @param appQuit
              Severity: Minor
              Found in app/src/components/menu/menu.js - About 2 hrs to fix

                File cli.js has 262 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                #! /usr/bin/env node
                
                import 'source-map-support/register';
                import program from 'commander';
                import nativefier from './index';
                Severity: Minor
                Found in src/cli.js - About 2 hrs to fix

                  Function createTrayIcon has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function createTrayIcon(inpOptions, mainWindow) {
                    const options = Object.assign({}, inpOptions);
                  
                    if (options.tray) {
                      const iconPath = getAppIcon();
                  Severity: Major
                  Found in app/src/components/trayIcon/trayIcon.js - About 2 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language