jjbohn/omniauth-openid-connect

View on GitHub

Showing 2 of 2 total issues

Class OpenIDConnect has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

    class OpenIDConnect
      include OmniAuth::Strategy

      option :client_options, {
        identifier: nil,
Severity: Minor
Found in lib/omniauth/strategies/openid_connect.rb - About 2 hrs to fix

    Method callback_phase has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

          def callback_phase
            error = request.params['error_reason'] || request.params['error']
            if error
              raise CallbackError.new(request.params['error'], request.params['error_description'] || request.params['error_reason'], request.params['error_uri'])
            elsif request.params['state'].to_s.empty? || request.params['state'] != stored_state
    Severity: Minor
    Found in lib/omniauth/strategies/openid_connect.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language