Sign upLogin

jkphl/rdfa-lite-microdata

View on GitHub
Star

Showing 23 of 23 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testMicrodataHtmlDom()
    {
        $htmlDomFactory = new HtmlDocumentFactory();
        $dom = $htmlDomFactory->createDocumentFromSource(
            file_get_contents(
Severity: Major
Found in src/RdfaLiteMicrodata/Tests/Ports/MicrodataParserTest.php and 1 other location - About 3 hrs to fix
src/RdfaLiteMicrodata/Tests/Ports/RdfaLiteParserTest.php on lines 95..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 148.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testRdfaLiteDom()
    {
        $htmlDomFactory = new HtmlDocumentFactory();
        $dom = $htmlDomFactory->createDocumentFromSource(
            file_get_contents(
Severity: Major
Found in src/RdfaLiteMicrodata/Tests/Ports/RdfaLiteParserTest.php and 1 other location - About 3 hrs to fix
src/RdfaLiteMicrodata/Tests/Ports/MicrodataParserTest.php on lines 94..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 148.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testMicrodataHtmlFileWithIris()
    {
        $things = (new Microdata(true))->parseHtmlFile(
            dirname(__DIR__).DIRECTORY_SEPARATOR.'Fixtures'.DIRECTORY_SEPARATOR.'movie-microdata.html'
        );
Severity: Major
Found in src/RdfaLiteMicrodata/Tests/Ports/MicrodataParserTest.php and 1 other location - About 2 hrs to fix
src/RdfaLiteMicrodata/Tests/Ports/RdfaLiteParserTest.php on lines 74..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testRdfaLiteHtmlFileWithIris()
    {
        $things = (new RdfaLite(true))->parseHtmlFile(
            dirname(__DIR__).DIRECTORY_SEPARATOR.'Fixtures'.DIRECTORY_SEPARATOR.'article-rdfa-lite.html'
        );
Severity: Major
Found in src/RdfaLiteMicrodata/Tests/Ports/RdfaLiteParserTest.php and 1 other location - About 2 hrs to fix
src/RdfaLiteMicrodata/Tests/Ports/MicrodataParserTest.php on lines 74..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function testAnonymousItemWithPropertyRefs()
    {
        $things = (new Microdata())->parseHtmlFile(
            dirname(__DIR__).DIRECTORY_SEPARATOR.'Fixtures'.DIRECTORY_SEPARATOR.'anonymous-ref-microdata.html'
        );
Severity: Major
Found in src/RdfaLiteMicrodata/Tests/Ports/MicrodataParserTest.php and 3 other locations - About 1 hr to fix
src/RdfaLiteMicrodata/Tests/Ports/MicrodataParserTest.php on lines 54..69
src/RdfaLiteMicrodata/Tests/Ports/RdfaLiteParserTest.php on lines 54..69
src/RdfaLiteMicrodata/Tests/Ports/RdfaLiteParserTest.php on lines 154..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function testMicrodataHtmlFile()
    {
        $things = (new Microdata())->parseHtmlFile(
            dirname(__DIR__).DIRECTORY_SEPARATOR.'Fixtures'.DIRECTORY_SEPARATOR.'movie-microdata.html'
        );
Severity: Major
Found in src/RdfaLiteMicrodata/Tests/Ports/MicrodataParserTest.php and 3 other locations - About 1 hr to fix
src/RdfaLiteMicrodata/Tests/Ports/MicrodataParserTest.php on lines 118..135
src/RdfaLiteMicrodata/Tests/Ports/RdfaLiteParserTest.php on lines 54..69
src/RdfaLiteMicrodata/Tests/Ports/RdfaLiteParserTest.php on lines 154..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function testRdfaLiteHtmlFile()
    {
        $things = (new RdfaLite())->parseHtmlFile(
            dirname(__DIR__).DIRECTORY_SEPARATOR.'Fixtures'.DIRECTORY_SEPARATOR.'article-rdfa-lite.html'
        );
Severity: Major
Found in src/RdfaLiteMicrodata/Tests/Ports/RdfaLiteParserTest.php and 3 other locations - About 1 hr to fix
src/RdfaLiteMicrodata/Tests/Ports/MicrodataParserTest.php on lines 54..69
src/RdfaLiteMicrodata/Tests/Ports/MicrodataParserTest.php on lines 118..135
src/RdfaLiteMicrodata/Tests/Ports/RdfaLiteParserTest.php on lines 154..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function testRdfaLiteXmlFile()
    {
        $things = (new RdfaLite())->parseXmlFile(
            dirname(__DIR__).DIRECTORY_SEPARATOR.'Fixtures'.DIRECTORY_SEPARATOR.'typed-property-rdfa-lite.xhtml'
        );
Severity: Major
Found in src/RdfaLiteMicrodata/Tests/Ports/RdfaLiteParserTest.php and 3 other locations - About 1 hr to fix
src/RdfaLiteMicrodata/Tests/Ports/MicrodataParserTest.php on lines 54..69
src/RdfaLiteMicrodata/Tests/Ports/MicrodataParserTest.php on lines 118..135
src/RdfaLiteMicrodata/Tests/Ports/RdfaLiteParserTest.php on lines 54..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid excessively long class names like RdfaLiteMicrodataInfrastructureExceptionInterface. Keep class name length under 40.
Open

interface RdfaLiteMicrodataInfrastructureExceptionInterface extends RdfaLiteMicrodataExceptionInterface
{

}
Severity: Minor
Found in src/RdfaLiteMicrodata/Infrastructure/Exceptions/RdfaLiteMicrodataInfrastructureExceptionInterface.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

Avoid excessively long class names like RdfaLiteMicrodataDomainExceptionInterface. Keep class name length under 40.
Open

interface RdfaLiteMicrodataDomainExceptionInterface extends RdfaLiteMicrodataExceptionInterface
{

}
Severity: Minor
Found in src/RdfaLiteMicrodata/Domain/Exceptions/RdfaLiteMicrodataDomainExceptionInterface.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

Avoid excessively long class names like RdfaLiteMicrodataApplicationExceptionInterface. Keep class name length under 40.
Open

interface RdfaLiteMicrodataApplicationExceptionInterface extends RdfaLiteMicrodataExceptionInterface
{

}
Severity: Minor
Found in src/RdfaLiteMicrodata/Application/Exceptions/RdfaLiteMicrodataApplicationExceptionInterface.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testEmptyDefaultVocabulary()
    {
        $htmlDocumentFactory = new HtmlDocumentFactory();
        $rdfaElementProcessor = (new RdfaLiteElementProcessor)->setHtml(true);
        $rdfaContext = new RdfaLiteContext();
Severity: Major
Found in src/RdfaLiteMicrodata/Tests/Application/ParserTest.php and 1 other location - About 1 hr to fix
src/RdfaLiteMicrodata/Tests/Application/ParserTest.php on lines 113..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function testUnknownVocabularyPrefix()
    {
        $htmlDocumentFactory = new HtmlDocumentFactory();
        $rdfaElementProcessor = (new RdfaLiteElementProcessor)->setHtml(true);
        $rdfaContext = new RdfaLiteContext();
Severity: Major
Found in src/RdfaLiteMicrodata/Tests/Application/ParserTest.php and 1 other location - About 1 hr to fix
src/RdfaLiteMicrodata/Tests/Application/ParserTest.php on lines 96..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method processPropertyPrefixName has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    protected function processPropertyPrefixName($prefix, $name, \DOMElement $element, ContextInterface $context, $last)
Severity: Minor
Found in src/RdfaLiteMicrodata/Infrastructure/Parser/PropertyProcessorTrait.php - About 35 mins to fix

    Method addProperty has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            \DOMElement $element,
        ContextInterface $context,
        $name,
        VocabularyInterface $vocabulary,
        $last
    Severity: Minor
    Found in src/RdfaLiteMicrodata/Infrastructure/Parser/PropertyProcessorTrait.php - About 35 mins to fix

      The method __construct has a boolean flag argument $iri, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function __construct($iri = false)
      Severity: Minor
      Found in src/RdfaLiteMicrodata/Ports/Parser/AbstractParser.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '57', column '20').
      Open

              $dom = new \DOMDocument();
      Severity: Minor
      Found in src/RdfaLiteMicrodata/Infrastructure/Factories/XmlDocumentFactory.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '116', column '20').
      Open

              $dom = new \DOMDocument();
      Severity: Minor
      Found in src/RdfaLiteMicrodata/Tests/Application/DOMIteratorTest.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '150', column '20').
      Open

              return new \RecursiveIteratorIterator($this, \RecursiveIteratorIterator::SELF_FIRST);
      Severity: Minor
      Found in src/RdfaLiteMicrodata/Application/Parser/DOMIterator.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '54', column '20').
      Open

              $dom = new \DOMDocument();
      Severity: Minor
      Found in src/RdfaLiteMicrodata/Tests/Infrastructure/DomDocumentFactoryTest.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Severity
      Category
      Status
      Source
      Language