Sign upLogin

jmdobry/angular-data

View on GitHub
Star

Showing 21 of 21 total issues

Function constructor has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

  constructor () {
    let _this = this
    let deps = []

    for (var i = 0; i < adapters.length; i++) {
Severity: Minor
Found in src/index.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function startInjector has 204 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function startInjector() {
  inject(function (_$rootScope_, _$q_, _$timeout_, _$httpBackend_, _DS_, _$log_, _DSUtils_, _DSHttpAdapter_) {
    // Setup global mocks

    localStorage.clear()
Severity: Major
Found in karma.start.js - About 1 day to fix

    Function constructor has 124 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      constructor () {
    let _this = this
    let deps = []

    for (var i = 0; i < adapters.length; i++) {
    Severity: Major
    Found in src/index.js - About 4 hrs to fix

      File karma.start.js has 325 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      // Setup global test variables
var $rootScope, $q, $log, $timeout, DSHttpAdapterProvider, DSProvider, DS, DSUtils, DSHttpAdapter, app, $httpBackend, p1, p2, p3, p4, p5

var Post, User, Organization, Comment, Profile
var user1, organization2, comment3, profile4
      Severity: Minor
      Found in karma.start.js - About 3 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if (pkg.version.indexOf('beta') !== -1) {
    file = file.replace(/<%= beta %>/gi, parts[1].replace('beta.', '') + (parts.length > 2 ? '-' + parts[2] : ''))
  } else {
    file = file.replace(/<%= beta %>/gi, false)
  }
        Severity: Major
        Found in scripts/version.js and 1 other location - About 3 hrs to fix
        scripts/version.js on lines 20..24

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          if (pkg.version.indexOf('alpha') !== -1) {
    file = file.replace(/<%= alpha %>/gi, parts[1].replace('alpha.', '') + (parts.length > 2 ? '-' + parts[2] : ''))
  } else {
    file = file.replace(/<%= alpha %>/gi, false)
  }
        Severity: Major
        Found in scripts/version.js and 1 other location - About 3 hrs to fix
        scripts/version.js on lines 26..30

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        module.exports = {
  entry: './app.js',
  output: {
    filename: 'bundle.js'
  },
        Severity: Major
        Found in build_examples/webpack_es6_2/webpack.config.js and 1 other location - About 2 hrs to fix
        build_examples/webpack_es6/webpack.config.js on lines 1..17

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        module.exports = {
  entry: './app.js',
  output: {
    filename: 'bundle.js'
  },
        Severity: Major
        Found in build_examples/webpack_es6/webpack.config.js and 1 other location - About 2 hrs to fix
        build_examples/webpack_es6_2/webpack.config.js on lines 1..17

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function load has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function load (...args) {
      let $rootScope = args[args.length - 2]
      let $q = args[args.length - 1]
      let store = new JSData.DS(_this.defaults)
      let originals = {}
        Severity: Minor
        Found in src/index.js - About 1 hr to fix

          Function exports has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function (config) {
  config.set({
    basePath: './',
    frameworks: ['sinon', 'chai', 'mocha'],
    plugins: [
          Severity: Minor
          Found in karma.conf.js - About 1 hr to fix

            Function bindAll has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                JSData.DS.prototype.bindAll = function (resourceName, params, scope, expr, cb) {
      let _this = this

      params = params || {}
            Severity: Minor
            Found in src/index.js - About 1 hr to fix

              Function bindOne has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  JSData.DS.prototype.bindOne = function (resourceName, id, scope, expr, cb) {
      let _this = this

      id = resolveId(_this.definitions[resourceName], id)
      if (!_this.definitions[resourceName]) {
              Severity: Minor
              Found in src/index.js - About 1 hr to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                angular.module('app', [
  // this is what you would do in a real app
  // require('js-data-angular')

  // for the example to work
                Severity: Major
                Found in build_examples/webpack/app.js and 1 other location - About 1 hr to fix
                build_examples/browserify/app.js on lines 9..17

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 57.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                angular.module('app', [
  // this is what you would do in a real app
  // require('js-data-angular')

  // for the example to work
                Severity: Major
                Found in build_examples/browserify/app.js and 1 other location - About 1 hr to fix
                build_examples/webpack/app.js on lines 9..17

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 57.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                      } else if (!isObject(params)) {
        throw new DSErrors.IA('"params" must be an object!')
      } else if (!isObject(scope)) {
        throw new DSErrors.IA('"scope" must be an object!')
      } else if (!isString(expr)) {
                Severity: Minor
                Found in src/index.js and 1 other location - About 45 mins to fix
                src/index.js on lines 132..138

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                      } else if (!isString(id) && !isNumber(id)) {
        throw new DSErrors.IA('"id" must be a string or a number!')
      } else if (!isObject(scope)) {
        throw new DSErrors.IA('"scope" must be an object!')
      } else if (!isString(expr)) {
                Severity: Minor
                Found in src/index.js and 1 other location - About 45 mins to fix
                src/index.js on lines 94..100

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function version has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                function version (filepath) {
  var file = fs.readFileSync(filepath, {
    encoding: 'utf-8'
  })
                Severity: Minor
                Found in scripts/version.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    Organization = DS.defineResource({
      name: 'organization',
      relations: {
        hasMany: {
          user: {
                Severity: Minor
                Found in karma.start.js and 1 other location - About 40 mins to fix
                karma.start.js on lines 174..184

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    Profile = DS.defineResource({
      name: 'profile',
      relations: {
        belongsTo: {
          user: {
                Severity: Minor
                Found in karma.start.js and 1 other location - About 40 mins to fix
                karma.start.js on lines 162..172

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function bindOne has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    JSData.DS.prototype.bindOne = function (resourceName, id, scope, expr, cb) {
                Severity: Minor
                Found in src/index.js - About 35 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language