Sign upLogin

jmdobry/waterline-rethinkdb

View on GitHub
Star

Showing 25 of 25 total issues

File adapter.js has 384 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

var _ = require('underscore'),
    async = require('async'),
    Connection = require('./connection'),
Severity: Minor
Found in lib/adapter.js - About 5 hrs to fix

    Function define has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    RethinkDBAdapter.prototype.define = function define(collectionName, definition, cb) {

    var collection = this.getDef(collectionName),
        _this = this,
        tableCreateOptions = {},
    Severity: Minor
    Found in lib/adapter.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function Connection has 88 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function Connection(options) {

    ///////////////////////
    // Private variables //
    ///////////////////////
    Severity: Major
    Found in lib/connection.js - About 3 hrs to fix

      Function update has 81 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      RethinkDBAdapter.prototype.update = function update(collectionName, options, values, cb) {

    var collection = this.getDef(collectionName),
        _this = this;
      Severity: Major
      Found in lib/adapter.js - About 3 hrs to fix

        Function define has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        RethinkDBAdapter.prototype.define = function define(collectionName, definition, cb) {

    var collection = this.getDef(collectionName),
        _this = this,
        tableCreateOptions = {},
        Severity: Major
        Found in lib/adapter.js - About 2 hrs to fix

          Function Connection has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

          function Connection(options) {

    ///////////////////////
    // Private variables //
    ///////////////////////
          Severity: Minor
          Found in lib/connection.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function find has 51 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          RethinkDBAdapter.prototype.find = function find(collectionName, options, cb) {

    var collection = this.getDef(collectionName),
        _this = this;
          Severity: Major
          Found in lib/adapter.js - About 2 hrs to fix

            Function exports has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = function (grunt) {

    require('load-grunt-tasks')(grunt);
    require('time-grunt')(grunt);
            Severity: Minor
            Found in Gruntfile.js - About 1 hr to fix

              Function create has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              RethinkDBAdapter.prototype.create = function create(collectionName, values, cb) {

    var queries = [],
        collection = this.getDef(collectionName),
        _this = this;
              Severity: Minor
              Found in lib/adapter.js - About 1 hr to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                        }).update(values, { returnVals: true }), function (err, cursor) {
                            if (err) {
                                next(err);
                            } else if (cursor.errors > 0) {
                                next(cursor.first_error);
                Severity: Major
                Found in lib/adapter.js and 1 other location - About 1 hr to fix
                lib/adapter.js on lines 451..459

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 65.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                        _this.connectionRun(r.table(collectionName).get(options.where[collection.primaryKey || 'id']).update(values, { returnVals: true }), function (err, cursor) {
                            if (err) {
                                next(err);
                            } else if (cursor.errors > 0) {
                                next(cursor.first_error);
                Severity: Major
                Found in lib/adapter.js and 1 other location - About 1 hr to fix
                lib/adapter.js on lines 468..476

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 65.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function RethinkDBAdapter has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function RethinkDBAdapter(options) {

    ///////////////////////
    // Private variables //
    ///////////////////////
                Severity: Minor
                Found in lib/adapter.js - About 1 hr to fix

                  Function update has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                  RethinkDBAdapter.prototype.update = function update(collectionName, options, values, cb) {

    var collection = this.getDef(collectionName),
        _this = this;
                  Severity: Minor
                  Found in lib/adapter.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function create has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                  RethinkDBAdapter.prototype.create = function create(collectionName, values, cb) {

    var queries = [],
        collection = this.getDef(collectionName),
        _this = this;
                  Severity: Minor
                  Found in lib/adapter.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              _this.connectionRun(r.tableDrop(collectionName), function (err, result) {
                if (err) {
                    cb(err);
                } else if (result.dropped !== 1) {
                    cb('Failed to drop table: ' + collectionName);
                  Severity: Major
                  Found in lib/adapter.js and 1 other location - About 1 hr to fix
                  lib/adapter.js on lines 201..209

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 59.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  _this.connectionRun(r.tableCreate(collectionName, tableCreateOptions), function (err, result) {
                    if (err) {
                        next(err);
                    } else if (result.created !== 1) {
                        next('Failed to create table: ' + collectionName);
                  Severity: Major
                  Found in lib/adapter.js and 1 other location - About 1 hr to fix
                  lib/adapter.js on lines 252..260

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 59.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function _configure has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      function _configure(options, strict) {
        var errorPrefix = 'Connection.configure(options, strict): options';

        if (!_.isObject(options)) {
            throw new Error(errorPrefix + ': must be an object!');
                  Severity: Minor
                  Found in lib/connection.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (options.where[collection.primaryKey || 'id']) {
            this.connectionRun(r.table(collectionName).get(options.where[collection.primaryKey || 'id']).delete(), cb);
        } else {
            this.connectionRun(r.table(collectionName).filter(options.where).delete(), cb);
        }
                    Severity: Major
                    Found in lib/adapter.js and 1 other location - About 1 hr to fix
                    lib/adapter.js on lines 403..407

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 55.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (options.where[collection.primaryKey || 'id'] && options.limit === 1) {
            this.connectionRun(r.table(collectionName).get(options.where[collection.primaryKey || 'id']).count(), cb);
        } else {
            this.connectionRun(r.table(collectionName).filter(options.where).count(), cb);
        }
                    Severity: Major
                    Found in lib/adapter.js and 1 other location - About 1 hr to fix
                    lib/adapter.js on lines 524..528

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 55.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Avoid deeply nested control flow statements.
                    Open

                                                    if (result > 0) {
                                    cb('Unique constraint failure!');
                                } else {
                                    cb();
                                }
                    Severity: Major
                    Found in lib/adapter.js - About 45 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language