Sign upLogin

jnidzwetzki/bboxdb

View on GitHub
Star

Showing 788 of 966 total issues

Method equals has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public boolean equals(Object obj) {
        if (this == obj)
            return true;
        if (obj == null)
Severity: Minor
Found in bboxdb-server/src/main/java/org/bboxdb/storage/entity/TupleStoreMetaData.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method accept has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public void accept(final TupleStoreName tupleStoreName, final Tuple streamTuple) {
        
        final boolean processFurtherActions = processSpecialTuples(tupleStoreName, streamTuple);
Severity: Minor
Found in bboxdb-server/src/main/java/org/bboxdb/network/server/query/continuous/ContinuousSpatialJoinQuery.java - About 1 hr to fix

    Method run has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
    public void run() {
        
        try (
                final BufferedReader reader = Files.newBufferedReader(file.toPath(), Const.DEFAULT_CHARSET);
    Severity: Minor
    Found in bboxdb-tools/src/main/java/org/bboxdb/tools/network/CaptureStoredDataTimed.java - About 1 hr to fix

      Method handleQuery has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @Override
    /**
     * Handle a bounding box query
     */
    public void handleQuery(final ByteBuffer encodedPackage,
      Severity: Minor
      Found in bboxdb-server/src/main/java/org/bboxdb/network/server/connection/handler/query/HandleJoinQuery.java - About 1 hr to fix

        Method createBody has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected byte[] createBody() throws IOException {
        final ByteArrayOutputStream bodyStream = new ByteArrayOutputStream();
        
        // The global states
        final Map<String, Set<String>> globalActiveRangeQueryElements = continuousQueryServerState.getGlobalActiveRangeQueryElements();
        Severity: Minor
        Found in bboxdb-server/src/main/java/org/bboxdb/network/packets/response/ContinuousQueryStateResponse.java - About 1 hr to fix

          Method run has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              @Override
    public void run() {
        
        try (                
                final BufferedReader reader = Files.newBufferedReader(file.toPath(), Const.DEFAULT_CHARSET);
          Severity: Minor
          Found in bboxdb-tools/src/main/java/org/bboxdb/tools/network/CaptureStoredData.java - About 1 hr to fix

            Method run has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                @Override
    public void run() {
        try (
                final BBoxDBCluster bboxdbClient = new BBoxDBCluster(connectionPoint, clustername);
            ){
            Severity: Minor
            Found in bboxdb-tools/src/main/java/org/bboxdb/tools/network/CaptureAUTransportStream.java - About 1 hr to fix

              Method updateAircraft has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private Aircraft updateAircraft(final String[] data, final String transmissionType) 
            throws InputParseException, ParseException {
    
        final String hexIdent = data[4];
              Severity: Minor
              Found in bboxdb-tools/src/main/java/org/bboxdb/tools/converter/tuple/ADSBTupleBuilder2D.java - About 1 hr to fix

                Method buildTuple has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    @Override
    public Tuple buildTuple(final String valueData, final String keyData) {
        
        // Ignore the header
        if("Moid,Tripid,Tstart,Tend,Xstart,Ystart,Xend,Yend".equals(valueData)) {
                Severity: Minor
                Found in bboxdb-tools/src/main/java/org/bboxdb/tools/converter/tuple/BerlinModTupleBuilder.java - About 1 hr to fix

                  Method run has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      @Override
    public void run() {
        
        
        try (
                  Severity: Minor
                  Found in bboxdb-tools/src/main/java/org/bboxdb/tools/network/CaptureADSB.java - About 1 hr to fix

                    Method run has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                    Open

                        @Override
    public void run() {
        
        
        try (
                    Severity: Minor
                    Found in bboxdb-tools/src/main/java/org/bboxdb/tools/network/CaptureADSB.java - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method handleQuery has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                    Open

                        @Override
    /**
     * Handle a bounding box query
     */
    public void handleQuery(final ByteBuffer encodedPackage,
                    Severity: Minor
                    Found in bboxdb-server/src/main/java/org/bboxdb/network/server/connection/handler/query/HandleJoinQuery.java - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method fetchAndSendNextTuples has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                    Open

                        @Override
    public void fetchAndSendNextTuples(final short packageSequence) throws IOException, PacketEncodeException {

        long sendTuplesInThisPage = 0;
        clientConnectionHandler.writeResultPackage(new MultipleTupleStartResponse(packageSequence));
                    Severity: Minor
                    Found in bboxdb-server/src/main/java/org/bboxdb/network/server/query/StreamClientQuery.java - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method getSystemsToConnectForStateSync has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                    Open

                        @VisibleForTesting
    public Set<BBoxDBInstance> getSystemsToConnectForStateSync(final DistributionRegion region) {
        final Set<BBoxDBInstance> systemsToRequst = new HashSet<>();
        
        if(region.isLeafRegion()) {
                    Severity: Minor
                    Found in bboxdb-server/src/main/java/org/bboxdb/network/server/connection/NetworkConnectionService.java - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method equals has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                    Open

                        @Override
    public boolean equals(final Object obj) {
        if (this == obj)
            return true;
        if (obj == null)
                    Severity: Minor
                    Found in bboxdb-server/src/main/java/org/bboxdb/network/packets/request/LockTupleRequest.java - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method decodePackage has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public static ContinuousQueryStateResponse decodePackage(final ByteBuffer encodedPackage) throws PacketEncodeException {        
        final short requestId = NetworkPackageDecoder.getRequestIDFromResponsePackage(encodedPackage);

        final boolean decodeResult = NetworkPackageDecoder.validateResponsePackageHeader(encodedPackage, NetworkConst.RESPONSE_CONTINUOUS_QUERY_STATE);
                    Severity: Minor
                    Found in bboxdb-server/src/main/java/org/bboxdb/network/packets/response/ContinuousQueryStateResponse.java - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method equals has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                    Open

                        @Override
    public boolean equals(Object obj) {
        if (this == obj)
            return true;
        if (obj == null)
                    Severity: Minor
                    Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method performReadRepairForResult has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private void performReadRepairForResult(final List<Tuple> allTuples, int resultId)
            throws InterruptedException, BBoxDBException, ZookeeperException {

        @SuppressWarnings("unchecked")
        final List<Tuple> tupleResult = (List<Tuple>) futures.get(resultId).get(true);
                    Severity: Minor
                    Found in bboxdb-server/src/main/java/org/bboxdb/network/client/future/client/ReadRepair.java - About 1 hr to fix

                      Similar blocks of code found in 5 locations. Consider refactoring.
                      Open

                                  case QUERY_PREDEFINED_BUS_FOREST_RELAXTED:
                udfNameField.setText(UserDefinedGeoJsonSpatialFilter.class.getCanonicalName());
                udfValueField.setText("");
                table1Field.setSelectedItem("osmgroup_buses");
                table2Field.setSelectedItem("osmgroup_forests");
                      Severity: Major
                      Found in bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java and 4 other locations - About 1 hr to fix
                      bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 410..424
                      bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 425..439
                      bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 440..454
                      bboxdb-tools/src/main/java/org/bboxdb/tools/gui/views/query/QueryWindow.java on lines 485..499

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 112.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                      /*******************************************************************************
 *
 *    Copyright (C) 2015-2022 the BBoxDB project
 *  
 *    Licensed under the Apache License, Version 2.0 (the "License");
                      Severity: Major
                      Found in bboxdb-server/src/main/java/org/bboxdb/network/packets/response/PageEndResponse.java and 2 other locations - About 1 hr to fix
                      bboxdb-server/src/main/java/org/bboxdb/network/packets/response/MultipleTupleEndResponse.java on lines 1..68
                      bboxdb-server/src/main/java/org/bboxdb/network/packets/response/MultipleTupleStartResponse.java on lines 1..68

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 112.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language