Sign upLogin

joehecn/j

View on GitHub
Star

Showing 19 of 21 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  test('sendImgMsgs 请先选择要发送给哪些人或群', () => {
    expect.assertions(1)

    const { wrapper } = createStoreAndWrapper(false)
    wrapper.find('#send-img-btn').trigger('click')
Severity: Major
Found in __tests__/components/SendMessage.test.js and 1 other location - About 3 hrs to fix
__tests__/components/SendMessage.test.js on lines 49..61

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  test('sendTextMsgs 不能发送空消息', () => {
    expect.assertions(1)

    const { wrapper } = createStoreAndWrapper(false)
    wrapper.find('#send-text-btn').trigger('click')
Severity: Major
Found in __tests__/components/SendMessage.test.js and 1 other location - About 3 hrs to fix
__tests__/components/SendMessage.test.js on lines 163..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

methods has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

const methods = {
  //////////////////
  // robot

  // login.start()
Severity: Minor
Found in src/renderer/worker/worker.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      test('setRepeatNameList', () => {
    expect.assertions(1)

    const list = [ 'hehe' ]
    mutations.setRepeatNameList(state, { list })
    Severity: Major
    Found in __tests__/store/mutations.test.js and 1 other location - About 1 hr to fix
    __tests__/store/mutations.test.js on lines 127..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      test('setGroupList', () => {
    expect.assertions(1)

    const groupList = [ 'hehe' ]
    mutations.setGroupList(state, { groupList })
    Severity: Major
    Found in __tests__/store/mutations.test.js and 1 other location - About 1 hr to fix
    __tests__/store/mutations.test.js on lines 118..125

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function sendmsgBack has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async sendmsgBack (value) {
    let msg = await db('getItem', {
      name: Uin,
      storeName: 'msg',
      key: value.key
    Severity: Minor
    Found in src/renderer/worker/back.worker.js - About 1 hr to fix

      Function sendmsg has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async sendmsg(value) {
    // db
    // { key: { Type, (Content || file), tos: { premd5: failCount } } }
    const key = (+new Date() + Math.random().toFixed(3)).replace('.', '')
      Severity: Minor
      Found in src/renderer/worker/back.worker.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              listB: [{
        premd5: 'B120b1df75e335bb5bedbc198c53b4fe9',
        NickName: 'jjjoe',
        RemarkName: '',
        status: 2
        Severity: Minor
        Found in __tests__/worker/data.test.js and 1 other location - About 45 mins to fix
        __tests__/worker/data.test.js on lines 59..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              listM: [{
        premd5: 'Mbf403351dfb2ae819874163aff25a49c',
        NickName: 'joe1',
        RemarkName: '',
        status: 1
        Severity: Minor
        Found in __tests__/worker/data.test.js and 1 other location - About 45 mins to fix
        __tests__/worker/data.test.js on lines 70..80

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            webwxapi.webwxsync({}).catch(error => {
      expect(error.status).toBe(807)
      expect(error.message).toBe('更新 SyncKey 失败')
    })
        Severity: Major
        Found in __tests__/robot/webwxapi/index.webwxsync.test.js and 5 other locations - About 35 mins to fix
        __tests__/robot/webwxapi/fun.test.js on lines 161..164
        __tests__/robot/webwxapi/index.webwxbatchgetcontact.test.js on lines 44..47
        __tests__/robot/webwxapi/index.webwxgetcontact.test.js on lines 42..45
        __tests__/robot/webwxapi/index.webwxinit.test.js on lines 32..35
        __tests__/worker/db.test.js on lines 61..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

              getBaseRequest('').catch(error => {
        expect(error.status).toBe(904)
        expect(error.message).toBe('获取 BaseRequest 失败')
      })
        Severity: Major
        Found in __tests__/robot/webwxapi/fun.test.js and 5 other locations - About 35 mins to fix
        __tests__/robot/webwxapi/index.webwxbatchgetcontact.test.js on lines 44..47
        __tests__/robot/webwxapi/index.webwxgetcontact.test.js on lines 42..45
        __tests__/robot/webwxapi/index.webwxinit.test.js on lines 32..35
        __tests__/robot/webwxapi/index.webwxsync.test.js on lines 44..47
        __tests__/worker/db.test.js on lines 61..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          test('getMemberlist', () => {
    const data = {
      key: 'getMemberlist',
      value: 2
    }
        Severity: Minor
        Found in __tests__/worker/worker.test.js and 1 other location - About 35 mins to fix
        __tests__/worker/worker.test.js on lines 111..118

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            webwxapi.webwxgetcontact().catch(error => {
      expect(error.status).toBe(802)
      expect(error.message).toBe('获取好友列表失败')
    })
        Severity: Major
        Found in __tests__/robot/webwxapi/index.webwxgetcontact.test.js and 5 other locations - About 35 mins to fix
        __tests__/robot/webwxapi/fun.test.js on lines 161..164
        __tests__/robot/webwxapi/index.webwxbatchgetcontact.test.js on lines 44..47
        __tests__/robot/webwxapi/index.webwxinit.test.js on lines 32..35
        __tests__/robot/webwxapi/index.webwxsync.test.js on lines 44..47
        __tests__/worker/db.test.js on lines 61..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          test('batchlist', () => {
    const data = {
      key: 'batchlist',
      value: 1
    }
        Severity: Minor
        Found in __tests__/worker/worker.test.js and 1 other location - About 35 mins to fix
        __tests__/worker/worker.test.js on lines 85..92

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          test('getCode201', () => {
    const data = {
      key: 'getCode201',
      value: 'userAvatar'
    }
        Severity: Minor
        Found in __tests__/worker/worker.test.js and 1 other location - About 35 mins to fix
        __tests__/worker/worker.test.js on lines 24..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            db('setItem', {
      name: '123456',
      storeName: 'msg',
      key: '123',
      value: 'errorMsg'
        Severity: Major
        Found in __tests__/worker/db.test.js and 5 other locations - About 35 mins to fix
        __tests__/robot/webwxapi/fun.test.js on lines 161..164
        __tests__/robot/webwxapi/index.webwxbatchgetcontact.test.js on lines 44..47
        __tests__/robot/webwxapi/index.webwxgetcontact.test.js on lines 42..45
        __tests__/robot/webwxapi/index.webwxinit.test.js on lines 32..35
        __tests__/robot/webwxapi/index.webwxsync.test.js on lines 44..47

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            webwxapi.webwxinit('', {}).catch(error => {
      expect(error.status).toBe(800)
      expect(error.message).toBe('获取 User 失败')
    })
        Severity: Major
        Found in __tests__/robot/webwxapi/index.webwxinit.test.js and 5 other locations - About 35 mins to fix
        __tests__/robot/webwxapi/fun.test.js on lines 161..164
        __tests__/robot/webwxapi/index.webwxbatchgetcontact.test.js on lines 44..47
        __tests__/robot/webwxapi/index.webwxgetcontact.test.js on lines 42..45
        __tests__/robot/webwxapi/index.webwxsync.test.js on lines 44..47
        __tests__/worker/db.test.js on lines 61..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          test('getUUID', () => {
    const data = {
      key: 'getUUID',
      value: 'uuid'
    }
        Severity: Minor
        Found in __tests__/worker/worker.test.js and 1 other location - About 35 mins to fix
        __tests__/worker/worker.test.js on lines 33..40

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

            webwxapi.webwxbatchgetcontact('', {}, []).catch(error => {
      expect(error.status).toBe(808)
      expect(error.message).toBe('获取聊天群列表失败')
    })
        Severity: Major
        Found in __tests__/robot/webwxapi/index.webwxbatchgetcontact.test.js and 5 other locations - About 35 mins to fix
        __tests__/robot/webwxapi/fun.test.js on lines 161..164
        __tests__/robot/webwxapi/index.webwxgetcontact.test.js on lines 42..45
        __tests__/robot/webwxapi/index.webwxinit.test.js on lines 32..35
        __tests__/robot/webwxapi/index.webwxsync.test.js on lines 44..47
        __tests__/worker/db.test.js on lines 61..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language