joelongstreet/flapi

View on GitHub
lib/flapi.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function api has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

flapi.prototype.api = function(opts){

  if(!opts.method){
    throw new Error('Please pass an api method option as "method". You can find all available flickr methods within the flickr documentation at http://www.flickr.com/services/api/');
  }
Severity: Minor
Found in lib/flapi.js - About 1 hr to fix

    Function authApp has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    flapi.prototype.authApp = function(authCallbackURL, next){
      var self = this;
      var message = 'Please visit the flickr documentation http://www.flickr.com/services/api/, or retrieve your app creds here http://www.flickr.com/services/apps, or create an app here http://www.flickr.com/services/apps/create/ \n';
    
      if(!this.settings.oauth_consumer_key){
    Severity: Minor
    Found in lib/flapi.js - About 1 hr to fix

      Function api has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      flapi.prototype.api = function(opts){
      
        if(!opts.method){
          throw new Error('Please pass an api method option as "method". You can find all available flickr methods within the flickr documentation at http://www.flickr.com/services/api/');
        }
      Severity: Minor
      Found in lib/flapi.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status