johnbellone/consul-cookbook

View on GitHub
libraries/consul_config_v0.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method params_to_json has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def params_to_json
        for_keeps = %i(
          acl_agent_token
          acl_agent_master_token
          acl_datacenter
Severity: Major
Found in libraries/consul_config_v0.rb - About 4 hrs to fix

    File consul_config_v0.rb has 257 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'poise'
    require_relative 'helpers'
    
    module ConsulCookbook
      module Resource
    Severity: Minor
    Found in libraries/consul_config_v0.rb - About 2 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            action(:create) do
              notifying_block do
                [::File.dirname(new_resource.path), new_resource.config_dir].each do |dir|
                  directory dir do
                    recursive true
      Severity: Major
      Found in libraries/consul_config_v0.rb and 1 other location - About 1 hr to fix
      libraries/consul_config_v1.rb on lines 290..311

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status