johnbellone/consul-cookbook

View on GitHub
libraries/consul_config_v1.rb

Summary

Maintainability
D
1 day
Test Coverage

Method params_to_json has 137 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def params_to_json
        for_keeps = %i(
          acl_agent_token
          acl_agent_master_token
          acl_datacenter
Severity: Major
Found in libraries/consul_config_v1.rb - About 5 hrs to fix

    Method params_to_json has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

          def params_to_json
            for_keeps = %i(
              acl_agent_token
              acl_agent_master_token
              acl_datacenter
    Severity: Minor
    Found in libraries/consul_config_v1.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File consul_config_v1.rb has 289 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'poise'
    require_relative 'helpers'
    
    module ConsulCookbook
      module Resource
    Severity: Minor
    Found in libraries/consul_config_v1.rb - About 2 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            action(:create) do
              notifying_block do
                [::File.dirname(new_resource.path), new_resource.config_dir].each do |dir|
                  directory dir do
                    recursive true
      Severity: Major
      Found in libraries/consul_config_v1.rb and 1 other location - About 1 hr to fix
      libraries/consul_config_v0.rb on lines 256..277

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if raw_config[:retry_join_ec2]
                Chef::Log.warn("Parameter 'retry_join_ec2' is deprecated")
                join_string = consul_cloud_join_string('aws', retry_join_ec2)
                existing_retry_join = raw_config[:retry_join]
                raw_config[:retry_join] = if existing_retry_join.nil?
      Severity: Minor
      Found in libraries/consul_config_v1.rb and 1 other location - About 25 mins to fix
      libraries/consul_config_v1.rb on lines 234..241

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if raw_config[:retry_join_azure]
                Chef::Log.warn("Parameter 'retry_join_azure' is deprecated")
                join_string = consul_cloud_join_string('azure', retry_join_azure)
                existing_retry_join = raw_config[:retry_join]
                raw_config[:retry_join] = if existing_retry_join.nil?
      Severity: Minor
      Found in libraries/consul_config_v1.rb and 1 other location - About 25 mins to fix
      libraries/consul_config_v1.rb on lines 224..231

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status