Sign upLogin

johnsonjh/gfsmux

View on GitHub
Star

Showing 24 of 29 total issues

File stream.go has 715 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package gfsmux

import (
    "encoding/binary"
    "io"
Severity: Minor
Found in stream.go - About 7 hrs to fix

    File session.go has 709 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    package gfsmux

import (
    "container/heap"
    "encoding/binary"
    Severity: Minor
    Found in session.go - About 7 hrs to fix

      Method Session.recvLoop has a Cognitive Complexity of 55 (exceeds 20 allowed). Consider refactoring.
      Open

      func (
    s *Session,
) recvLoop() {
    var hdr rawHeader
    var updHdr updHeader
      Severity: Minor
      Found in session.go - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Session.recvLoop has 113 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (
    s *Session,
) recvLoop() {
    var hdr rawHeader
    var updHdr updHeader
      Severity: Major
      Found in session.go - About 3 hrs to fix

        Method Stream.writeV2 has 95 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (
    s *Stream,
) writeV2(
    b []byte,
) (
        Severity: Major
        Found in stream.go - About 2 hrs to fix

          Stream has 23 methods (exceeds 20 allowed). Consider refactoring.
          Open

          type Stream struct {
    id   uint32
    sess *Session

    // slice heads kept for recycle
          Severity: Minor
          Found in stream.go - About 2 hrs to fix

            Session has 22 methods (exceeds 20 allowed). Consider refactoring.
            Open

            type Session struct {
    Conn io.ReadWriteCloser

    Config           *Config
    nextStreamID     uint32 // next stream identifier
            Severity: Minor
            Found in session.go - About 2 hrs to fix

              Method Stream.writeV2 has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
              Open

              func (
    s *Stream,
) writeV2(
    b []byte,
) (
              Severity: Minor
              Found in stream.go - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method Session.sendLoop has 67 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func (
    s *Session,
) sendLoop() {
    var buf []byte
    var n int
              Severity: Minor
              Found in session.go - About 1 hr to fix

                Method Stream.writeTov2 has 55 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func (
    s *Stream,
) writeTov2(
    w io.Writer,
) (
                Severity: Minor
                Found in stream.go - About 1 hr to fix

                  Method Stream.tryReadv2 has 51 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                  func (
    s *Stream,
) tryReadv2(
    b []byte,
) (
                  Severity: Minor
                  Found in stream.go - About 1 hr to fix

                    Function VerifyConfig has 10 return statements (exceeds 4 allowed).
                    Open

                    func VerifyConfig(
    Config *Config,
) error {
    if !(Config.Version == 1 || Config.Version == 2) {
        return errors.New(
                    Severity: Major
                    Found in mux.go - About 1 hr to fix

                      Method Stream.writeV2 has 9 return statements (exceeds 4 allowed).
                      Open

                      func (
    s *Stream,
) writeV2(
    b []byte,
) (
                      Severity: Major
                      Found in stream.go - About 55 mins to fix

                        Method Session.OpenStream has 8 return statements (exceeds 4 allowed).
                        Open

                        func (
    s *Session,
) OpenStream() (
    *Stream,
    error,
                        Severity: Major
                        Found in session.go - About 50 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                              if written, err := io.ReadFull(
                        s.Conn,
                        newbuf,
                    ); err == nil {
                        s.streamLock.Lock()
                          Severity: Major
                          Found in session.go - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                select {
                    case s.chAccepts <- stream:
                    case <-s.die:
                    }
                            Severity: Major
                            Found in session.go - About 45 mins to fix

                              Method Stream.waitRead has 7 return statements (exceeds 4 allowed).
                              Open

                              func (
    s *Stream,
) waitRead() error {
    var timer *time.Timer
    var deadline <-chan time.Time
                              Severity: Major
                              Found in stream.go - About 45 mins to fix

                                Method Session.WriteFrameInternal has 7 return statements (exceeds 4 allowed).
                                Open

                                func (
    s *Session,
) WriteFrameInternal(
    f Frame,
    deadline <-chan time.Time,
                                Severity: Major
                                Found in session.go - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                      if stream, ok := s.streams[Sid]; ok {
                        stream.update(
                            updHdr.Consumed(),
                            updHdr.Window(),
                        )
                                  Severity: Major
                                  Found in session.go - About 45 mins to fix

                                    Method Session.recvLoop has 6 return statements (exceeds 4 allowed).
                                    Open

                                    func (
    s *Session,
) recvLoop() {
    var hdr rawHeader
    var updHdr updHeader
                                    Severity: Major
                                    Found in session.go - About 40 mins to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language