Showing 1,896 of 2,859 total issues

Function shouldUpdate has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function shouldUpdate (args, dir, dep, has, req, depth, cb, type) {
  // look up the most recent version.
  // if that's what we already have, or if it's not on the args list,
  // then dive into it.  Otherwise, cb() with the data.

Severity: Major
Found in deps/npm/lib/outdated.js - About 3 hrs to fix

    File outdated.js has 303 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
    
    npm outdated [pkg]
    
    Does the following:
    Severity: Minor
    Found in deps/npm/lib/outdated.js - About 3 hrs to fix

      Function resolve has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      win32.resolve = function() {
        var resolvedDevice = '',
            resolvedTail = '',
            resolvedAbsolute = false;
      
      
      Severity: Minor
      Found in lib/path.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function write has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      CryptoStream.prototype._write = function write(data, encoding, cb) {
        assert(util.isNull(this._pending));
      
        // Black-hole data
        if (!this.pair.ssl) return cb(null);
      Severity: Minor
      Found in lib/_tls_legacy.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function bnToByteArray has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      function bnToByteArray() {
        var this_array = this.array;
        var i = this.t, r = new Array();
        r[0] = this.s;
        var p = BI_DB-(i*BI_DB)%8, d, k = 0;
      Severity: Minor
      Found in deps/v8/benchmarks/crypto.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getLite has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      function getLite (data, noname) {
        var lite = {}
          , maxDepth = npm.config.get("depth")
      
        if (!noname && data.name) lite.name = data.name
      Severity: Minor
      Found in deps/npm/lib/ls.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function save has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      Conf.prototype.save = function (where, cb) {
        var target = this.sources[where]
        if (!target || !(target.path || target.source) || !target.data) {
          if (where !== "builtin")
            var er = new Error("bad save target: " + where)
      Severity: Minor
      Found in deps/npm/lib/config/core.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _HandlePreCompiledHeaders has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      def _HandlePreCompiledHeaders(p, sources, spec):
        # Pre-compiled header source stubs need a different compiler flag
        # (generate precompiled header) and any source file not of the same
        # kind (i.e. C vs. C++) as the precompiled header source stub needs
        # to have use of precompiled headers disabled.
      Severity: Minor
      Found in tools/gyp/pylib/gyp/generator/msvs.py - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function WriteCopies has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      def WriteCopies(target_name, copies, extra_deps, path_to_gyp, output):
        """Write CMake for the 'copies' in the target.
      
        Args:
          target_name: the name of the CMake target being generated.
      Severity: Minor
      Found in tools/gyp/pylib/gyp/generator/cmake.py - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ProcessConditionsInDict has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      def ProcessConditionsInDict(the_dict, phase, variables, build_file):
        # Process a 'conditions' or 'target_conditions' section in the_dict,
        # depending on phase.
        # early -> conditions
        # late -> target_conditions
      Severity: Minor
      Found in tools/gyp/pylib/gyp/input.py - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _XCPrintableValue has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

        def _XCPrintableValue(self, tabs, value, flatten_list=False):
          """Returns a representation of value that may be printed in a project file,
          mimicing Xcode's behavior.
      
          _XCPrintableValue can handle str and int values, XCObjects (which are
      Severity: Minor
      Found in tools/gyp/pylib/gyp/xcodeproj_file.py - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function CheckStyle has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      def CheckStyle(filename, clean_lines, linenum, file_extension, error):
        """Checks rules from the 'C++ style rules' section of cppguide.html.
      
        Most of these rules are hard to test (naming, comment style), but we
        do what we can.  In particular we check for 2-space indents, line lengths,
      Severity: Minor
      Found in tools/cpplint.py - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function RunSingle has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

        def RunSingle(self):
          while not self.terminate:
            try:
              test = self.queue.get_nowait()
            except Empty:
      Severity: Minor
      Found in tools/test.py - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function FindJSBuiltins has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      def FindJSBuiltins():
        PATH = "src"
        fileslist = []
        for (root, dirs, files) in os.walk(PATH):
          for f in files:
      Severity: Minor
      Found in deps/v8/tools/generate-runtime-tests.py - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function startup has 81 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function startup() {
          var EventEmitter = NativeModule.require('events').EventEmitter;
      
          process.__proto__ = Object.create(EventEmitter.prototype, {
            constructor: {
      Severity: Major
      Found in src/node.js - About 3 hrs to fix

        Function renderScene has 80 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function renderScene(){
            var scene = new Flog.RayTracer.Scene();
        
            scene.camera = new Flog.RayTracer.Camera(
                                new Flog.RayTracer.Vector(0, 0, -15),
        Severity: Major
        Found in deps/v8/benchmarks/raytrace.js - About 3 hrs to fix

          File push_to_trunk.py has 299 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          #!/usr/bin/env python
          # Copyright 2013 the V8 project authors. All rights reserved.
          # Redistribution and use in source and binary forms, with or without
          # modification, are permitted provided that the following conditions are
          # met:
          Severity: Minor
          Found in deps/v8/tools/push-to-trunk/push_to_trunk.py - About 3 hrs to fix

            XCObject has 27 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class XCObject(object):
              """The abstract base of all class types used in Xcode project files.
            
              Class variables:
                _schema: A dictionary defining the properties of this class.  The keys to
            Severity: Minor
            Found in tools/gyp/pylib/gyp/xcodeproj_file.py - About 3 hrs to fix

              Function finishSection has 79 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function finishSection(section, parent) {
                if (!section || !parent) {
                  throw new Error('Invalid finishSection call\n'+
                                  JSON.stringify(section) + '\n' +
                                  JSON.stringify(parent));
              Severity: Major
              Found in tools/doc/json.js - About 3 hrs to fix

                Function _processChunk has 79 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                Zlib.prototype._processChunk = function(chunk, flushFlag, cb) {
                  var availInBefore = chunk && chunk.length;
                  var availOutBefore = this._chunkSize - this._offset;
                  var inOff = 0;
                
                
                Severity: Major
                Found in lib/zlib.js - About 3 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language